-
-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Date&Time settings label for "Date & Time" #1782
Conversation
4623463
to
4876860
Compare
Build checks have not completed. Possible reasons for this are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minimal change. Looks good. A rebase and conflicts resolved would be nice
I'm OK with this change, thanks @ajira86 for your contribution! I'm not sure why the CI is red for build-firmware, build-simulator and test-clang-tidy for such a small change. But since there's a conflict, I tried editing the PR by rebasing on main (since I'm suppose to have this privilege), but I honestly don't know how to make this right. @ajira86 could you rebase you change on main so we can merge it? |
If the ajira has "repository maintainers can edit this PR" or whatever the option is turned on, you should be able to (force) push directly to their branch IIRC. To do that you just clone their branch as usual and then push onto it, my preferred workflow is to add it as a new remote |
When I checkout the @ajira86 's branch, it's checked out as a detached head, so I'm not sure I can push it after I fix the conflict. |
4876860
to
ace7758
Compare
I've pushed it! |
@FintasticMan Thanks! :+1 I'll need to learn this feature from Github! The action build-firmware failed because of the "/" in the branch name so that's not an issue. I'll merge it! |
Proposal to update Date&Time label for issue #1746