Move MotorController to DisplayApp#1468
Merged
Riksu9000 merged 1 commit intoInfiniTimeOrg:developfrom Feb 25, 2023
Riksu9000:motor-is-ui
Merged
Move MotorController to DisplayApp#1468Riksu9000 merged 1 commit intoInfiniTimeOrg:developfrom Riksu9000:motor-is-ui
Riksu9000 merged 1 commit intoInfiniTimeOrg:developfrom
Riksu9000:motor-is-ui
Conversation
JF002
approved these changes
Dec 26, 2022
NeroBurner
reviewed
Jan 5, 2023
|
Build size and comparison to develop:
|
JF002
approved these changes
Feb 12, 2023
1 task
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
I've reverted creating the MotorController instance inside DisplayApp until we resolve #1583. |
Vibrations should be associated with something happening on the UI. Therefore SystemTask should not be controlling the motor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vibration is a user interface element and thus belongs in DisplayApp. Vibrations are now screen specific.