Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the size of the track and album name received by MusicService. #1036

Merged
merged 3 commits into from
Mar 21, 2022

Conversation

JF002
Copy link
Collaborator

@JF002 JF002 commented Mar 14, 2022

This should work around this bug : #825 and prevent heap over-allocation.

…This should work around this bug : #825 and prevent heap over-allocation.
@JF002 JF002 added the bug Something isn't working label Mar 14, 2022
@JF002 JF002 added this to the 1.9.0 milestone Mar 14, 2022
@Avamander
Copy link
Collaborator

Do you think 40 is enough, even with non-ASCII names? Or should we just look at it when it becomes an issue?

Also when truncated, maybe it should have an ellipsis at the end?

@JF002
Copy link
Collaborator Author

JF002 commented Mar 14, 2022

Do you think 40 is enough, even with non-ASCII names? Or should we just look at it when it becomes an issue?

Also when truncated, maybe it should have an ellipsis at the end?

According to my tests, the rendering time in LVGL takes too much time with more than 40-45 characters. That's why I chose this value :)

Regarding the ellipsis : yes, why not. How would you do it? Simply replace the last 3 characters by .?

@Avamander
Copy link
Collaborator

Regarding the ellipsis : yes, why not. How would you do it? Simply replace the last 3 characters by .?

If original exceeds 40, yes?

@JF002
Copy link
Collaborator Author

JF002 commented Mar 14, 2022

If original exceeds 40, yes?

Yes, of course :)

@JF002
Copy link
Collaborator Author

JF002 commented Mar 17, 2022

Here is the result with the ellipsis :)

music-ellipsis2.mp4

@JF002 JF002 merged commit 88197b6 into develop Mar 21, 2022
@Avamander Avamander deleted the music-service-limit-string-size branch September 27, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants