add CMake include and use its list for fonts#28
Closed
yehoshuapw wants to merge 1 commit intoInfiniTimeOrg:mainfrom
Closed
add CMake include and use its list for fonts#28yehoshuapw wants to merge 1 commit intoInfiniTimeOrg:mainfrom
yehoshuapw wants to merge 1 commit intoInfiniTimeOrg:mainfrom
Conversation
Author
|
I didn't realize in advance (never really used CMake before. always used plain make) that creating a variable will make it global, |
Contributor
|
I've just tried these changes but it doesn't seem to work for me :/ I'm not a CMake Guru either, but here's something we can try if your solution does not work : Implement the font generate Cmake code in a CMake function in a new file. Pass "source" and "output" directories as parameters to this function. Then, we should be able to include the function and to call this function from both InfiniTime and InfiniSim with correct arguments. |
Collaborator
|
closed in favor of #29 But thank you for the PR and the time you spent 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add method to work with InfiniTimeOrg/InfiniTime#1097
to CMake files.