Skip to content

add HardSigmoid cpu/cuda kernel #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Dev
merged 1 commit into from
Jan 18, 2024
Merged

add HardSigmoid cpu/cuda kernel #78

merged 1 commit into from
Jan 18, 2024

Conversation

@bitzyz
Copy link
Contributor

@bitzyz bitzyz commented Jan 17, 2024 •
edited
Loading

  • 前端算子测例
  • 前端算子
  • 计算图算子
  • kernel 测例
  • kernel cpu
  • kernel cuda
  • 模型端到端测试

@bitzyz bitzyz added kernel Add or modify kernel implementation operator Add or modify frontend/computation operator labels Jan 17, 2024
@bitzyz bitzyz self-assigned this Jan 17, 2024
YdrMaster
YdrMaster approved these changes Jan 17, 2024
View reviewed changes
src/04kernel/src/kernels/hard_sigmoid/cpu_kernel.cc Outdated
std::for_each_n(std::execution::par_unseq,
natural_t(0), size,
[&](auto i) {
y[i] = std::max(static_cast<T>(0), std::min(static_cast<T>(1), alpha_ * x[i] + beta_));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see https://zh.cppreference.com/w/cpp/algorithm/clamp

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

src/04kernel/src/kernels/hard_sigmoid/cpu_kernel.cc Outdated
UNREACHABLE();
}
}
}// namespace refactor::kernel No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缺换行

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

@bitzyz bitzyz force-pushed the dev-hardsigmoid branch 2 times, most recently from 0670c52 to 69bc0a2 Compare January 17, 2024 08:22
@YdrMaster YdrMaster merged commit 9e4789c into dev Jan 18, 2024
@YdrMaster YdrMaster deleted the dev-hardsigmoid branch January 18, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@YdrMaster YdrMaster YdrMaster approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bitzyz bitzyz

Labels

kernel Add or modify kernel implementation operator Add or modify frontend/computation operator

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bitzyz @YdrMaster