cores/psoc6: ./docs: Implement read resolution. #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-subramanyam
force-pushed
the
fix-adc-issues
branch
from
938f142 to
70f1881
Compare
Signed-off-by: Ramya Subramanyam <ramya.subramanyam@infineon.com>
ramya-subramanyam
force-pushed
the
fix-adc-issues
branch
from
70f1881 to
f20a225
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request implements a new read resolution API for the PSOC6 core while updating documentation to reflect the changes. Key changes include:
- Updating the Arduino deviations documentation to explain ADC read resolution behavior.
- Adding the analogReadResolution function and a resolution-mapping helper in cores/psoc6/analog_io.c.
- Updating the Arduino.h header to expose the new analogReadResolution API.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/arduino-deviations.rst | Updates documentation to describe ADC read resolution |
| cores/psoc6/analog_io.c | Implements analogReadResolution and maps ADC value |
| cores/psoc6/Arduino.h | Adds prototype for analogReadResolution |
Comments suppressed due to low confidence (1)
docs/arduino-deviations.rst:35
- Clarify in the docs that increasing resolution by left shifting (appending zeros) scales the ADC value without improving intrinsic measurement accuracy, which may affect how downstream calculations interpret the value.
The default ADC_RESOLUTION is fixed at 11 bits (range: 0–2047) due to hardware limitations.
| } | ||
|
|
||
| static inline uint32_t map_adc_value(uint32_t adc_value) { | ||
| uint8_t adc_res = ADC_RESOLUTION - 1; // 11-bit ADC resolution |
There was a problem hiding this comment.
Consider defining a separate constant (e.g. EFFECTIVE_ADC_RESOLUTION) rather than subtracting 1 from ADC_RESOLUTION to clearly differentiate between the hardware ADC width and the effective read resolution.
Suggested change
| uint8_t adc_res = ADC_RESOLUTION - 1; // 11-bit ADC resolution | |
| uint8_t adc_res = EFFECTIVE_ADC_RESOLUTION; // Effective ADC resolution |
ederjc
approved these changes
Jun 30, 2025
jaenrig-ifx
approved these changes
Jun 30, 2025
IFX-Anusha
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
ADC resolution is set to 12 bit hardcoded and cannot be changed. But the range is between 0 to 2047 which is upto 11 bits. This is because in single ended mode, the range is between 0 to 2047 when Vref is connected to GND as we can see in the TRM attached in the screenshot.
Now we have the ADC read resolution implemented. Also the negative values should not appear but in case the VSSA fluctuation 0 to -Vref, negative value appears.