Add HikariDataSource to mysql-loader

[HighVirus]

No description provided.

[davidmayr]

Seems fine to me. However, I don't use MySQL and I don't use HikariCP, so I don't know if the options the default constructor sets are just performance optimizations or things that should be set in order for this to work correctly.

Have you confirmed this to work with the HikariCP defaults? If yes, this is good to go.

[davidmayr]

Thinking about it, you could probably add an @ApiStatus.Experimental to the new constructor, so we could remove or rework this more easily if it causes issues.

[HighVirus]

Seems fine to me. However, I don't use MySQL and I don't use HikariCP, so I don't know if the options the default constructor sets are just performance optimizations or things that should be set in order for this to work correctly.

Have you confirmed this to work with the HikariCP defaults? If yes, this is good to go.

Each user is free and responsible for setting their own hikari parameters

[davidmayr]

Seems fine to me. However, I don't use MySQL and I don't use HikariCP, so I don't know if the options the default constructor sets are just performance optimizations or things that should be set in order for this to work correctly.
Have you confirmed this to work with the HikariCP defaults? If yes, this is good to go.

Each user is free and responsible for setting their own hikari parameters

I mean, yeah, sure, but we'd at least want to make sure it works with the defaults, right? Because if it doesn't work correctly with the defaults, we should probably add a notice to the docs which parameters are necessary.