Node-ID-Based Error Deduplication

[0xGeorgii]

Current implementation: String-based deduplication keys

fn push_error_dedup(&mut self, error: TypeCheckError) {
    let key = format!("UnknownType:{name}");
    // ...
}

It is better to migrate to ID-based deduplication for better performance and precision:

reported_errors: FxHashSet<(ErrorKind, u32)>  // (kind, node_id)

Benefits:

• More efficient than string allocation
• Distinguishes same name at different locations if needed
• Aligns with rust-analyzer's approach

[drips-wave]

This issue has been added to the Stellar Wave Program and is worth 100 Points.

🧑‍💻 Interested in contributing? Apply to work on this issue on Drips Wave, earn points, and receive rewards.

🤠 Repo maintainers: You can manage this issue's Points and Complexity on your Maintainer Dashboard here. Please keep an eye on applications and respond quickly 💙

ℹ️ Learn more about Drips Wave

[rosemary21]

@rosemary21 has applied to work on this issue as part of the Stellar Wave Program's 1st wave.

Why I’d like to work on this issue:
I’m interested in this task because error deduplication is a core part of compiler and static analysis performance, and migrating from string-based to node-ID-based deduplication will make the system more efficient, precise, and maintainable. I enjoy working on Rust backends and compiler-like tooling, where optimizing memory allocation and improving data structures can have measurable performance impact. Implementing this will also improve alignment with best practices seen in projects like rust-analyzer, which is valuable for long-term maintainability.

Relevant experience:

Proficient in Rust, including ownership, memory-efficient data structures, and HashSets/HashMaps.

Worked on compiler or analysis tools where error reporting and deduplication are critical.

Experienced in optimizing allocations, replacing expensive string operations with IDs or references.

Familiar with FxHashSet and custom key types for performance-sensitive Rust code.

Knowledge of static analysis patterns, including per-node error tracking and context-sensitive error reporting.

Experience in refactoring code for better alignment with upstream projects or standard approaches like rust-analyzer.

Proposed approach for this issue:

Replace the current string-based deduplication key with a tuple (ErrorKind, node_id: u32) stored in FxHashSet.

Update push_error_dedup to use this new key structure.

Ensure that errors with the same name but at different nodes are distinguished correctly.

Test that deduplication still prevents duplicate reports but now is more memory- and CPU-efficient.

Update any dependent logic that relied on string keys to use the new node-ID keys.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @rosemary21 to this issue.

[0xGeorgii]

Read this before starting any work: https://github.com/Inferara/inference/blob/main/CONTRIBUTING.md

[Arowolokehinde]

@Arowolokehinde has applied to work on this issue as part of the Stellar Wave Program's 1st wave.

can i work on this maintainer

I am an experienced backend engineer with deep knowledge of building scalable systems . i have a solid background in Rust and typescript
I have built, shipped, and contributed to projects using Soroban smart contracts, gaining hands-on experience writing efficient Rust programs and designing reliable test cases for real-world systems.

Please assign this issue to me

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Arowolokehinde to this issue.

[drips-wave]

Congratulations, @Arowolokehinde! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on January 31, 2026.

🧑‍💻 @Arowolokehinde: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

⚠️ Important: When opening a PR, please link it to this issue to ensure it gets tracked accurately.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[Arowolokehinde]

@0xGeorgii kindly review my pr

[Arowolokehinde]

@0xGeorgii can you review my PR?

[Arowolokehinde]

@0xGeorgii can you please review my pr