Skip to content

Upgrading stucked when resharding to empty a node #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
albertompe merged 2 commits into from
Jan 29, 2026
Merged

Upgrading stucked when resharding to empty a node #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c47f73
Check slots in importing state when stabilizing
albertompe Jan 27, 2026
2934692
Always renconcile when in Upgrading status
albertompe Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 23 additions & 9 deletions internal/cluster/redkey.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1764,18 +1764,32 @@ func (rc *RedKeyCluster) stabilizeOpenSlots(ctx context.Context, counter map[int
}

for _, clusterNode := range clusterNodes {
if clusterNode.ID == node.ID && len(clusterNode.Migrating) > 0 {
for slot := range clusterNode.Migrating {
if count, ok := counter[slot]; ok {
if count+1 > threshold {
slotsToStabilize = append(slotsToStabilize, MigratingSlot{Slot: slot, From: clusterNode.ID, To: clusterNode.Migrating[slot]})
if clusterNode.ID == node.ID {
if len(clusterNode.Migrating) > 0 {
for slot := range clusterNode.Migrating {
if count, ok := counter[slot]; ok {
if count+1 > threshold {
slotsToStabilize = append(slotsToStabilize, MigratingSlot{Slot: slot, From: clusterNode.ID, To: clusterNode.Migrating[slot]})
} else {
updatedCounter[slot] = count + 1
}
} else {
updatedCounter[slot] = count + 1
updatedCounter[slot] = 1
}
} else {
updatedCounter[slot] = 1
}
}
} else if len(clusterNode.Importing) > 0 {
for slot := range clusterNode.Importing {
if count, ok := counter[slot]; ok {
if count+1 > threshold {
slotsToStabilize = append(slotsToStabilize, MigratingSlot{Slot: slot, From: clusterNode.Importing[slot], To: clusterNode.ID})
} else {
updatedCounter[slot] = count + 1
}
} else {
updatedCounter[slot] = 1
}
}
}
}
}
}
Expand Down
4 changes: 0 additions & 4 deletions internal/reconciler/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,6 @@ func (r *RedKeyClusterReconciler) reconcileScalingDownStatus() error {

// reconcileUpgradingStatus reconciles the RedKey cluster when it is in the Upgrading status.
func (r *RedKeyClusterReconciler) reconcileUpgradingStatus() error {
// Check if the cluster needs to be upgraded
if r.cluster.IsUpgraded() {
return nil
}

// Upgrade the cluster
if err := r.cluster.Upgrade(true); err != nil {
Expand Down
Loading