Skip to content

Feat: improve CEL expression checks in mutating webhook configuration #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2025
Merged

Feat: improve CEL expression checks in mutating webhook configuration #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions internal/controller/overcommitclass/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,22 @@ func webhookChanged(updated, current interface{}) bool {
}
}

// Compare MatchConditions (including CEL expressions for namespace exclusion)
if len(updatedWebhook.MatchConditions) != len(currentWebhook.MatchConditions) {
return true
}

for i, updatedCondition := range updatedWebhook.MatchConditions {
if i >= len(currentWebhook.MatchConditions) {
return true
}
currentCondition := currentWebhook.MatchConditions[i]
if updatedCondition.Name != currentCondition.Name ||
updatedCondition.Expression != currentCondition.Expression {
return true
}
}

// If we reach here, they're likely the same
return false
}