New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute Fixes #183

Merged

tgross35 merged 4 commits into IndianBoy42:main from kennyp:main

Oct 27, 2024

Contributor

kennyp commented Oct 27, 2024 •

edited

Loading

Changes

Fix language detection when attribute has multiple arguments.
Fix attributes on alias

Related

This is a follow-up to Support Multiple Args for Attributes #177
Fixes Treesitter does not handle [private] alias #158
Fixes Support rule groups #176


          Fix multiple arguments to attribute.

a170c7a

kennyp marked this pull request as draft

October 27, 2024 12:46

Contributor Author

kennyp commented Oct 27, 2024

Converting to draft while I verify some other things locally.


          Use singular argument to match convention.

7bd561b

Contributor Author

kennyp commented Oct 27, 2024

Ready for review.

kennyp marked this pull request as ready for review

October 27, 2024 12:55


          Allow attributes on aliases.

2e639b4

Fixes IndianBoy42#158

kennyp mentioned this pull request

Treesitter does not handle [private] alias #158

Closed

kennyp changed the title ~~Fix multiple arguments to attribute.~~ Attribute Fixes

kennyp mentioned this pull request

Support rule groups #176

Closed

Collaborator

tgross35 commented Oct 27, 2024 •

edited

Loading

Thanks! Could you add a test in test/corpus/statements.txt for #158? and one to test/corpus/recipes.txt for #176?


          Add tests for issues IndianBoy42#158 and IndianBoy42#176.

2dc7f91

Contributor Author

kennyp commented Oct 27, 2024

@tgross35 good call. Tests have been added.

tgross35 merged commit 1014d2f into IndianBoy42:main

5 checks passed

Collaborator

tgross35 commented Oct 27, 2024

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet