Skip to content

chore: simplify examples involving lists #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stainless-app merged 1 commit into from
Jan 15, 2025
Merged

chore: simplify examples involving lists #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions increase-java-core/src/test/kotlin/com/increase/api/models/AchPrenotificationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,15 @@ class AchPrenotificationTest {
.creditDebitIndicator(AchPrenotification.CreditDebitIndicator.CREDIT)
.effectiveDate(null)
.idempotencyKey(null)
.notificationsOfChange(
listOf(
AchPrenotification.NotificationsOfChange.builder()
.changeCode(
AchPrenotification.NotificationsOfChange.ChangeCode
.INCORRECT_ACCOUNT_NUMBER
)
.correctedData("32")
.createdAt(OffsetDateTime.parse("2020-01-31T23:59:59Z"))
.build()
)
.addNotificationsOfChange(
AchPrenotification.NotificationsOfChange.builder()
.changeCode(
AchPrenotification.NotificationsOfChange.ChangeCode
.INCORRECT_ACCOUNT_NUMBER
)
.correctedData("32")
.createdAt(OffsetDateTime.parse("2020-01-31T23:59:59Z"))
.build()
)
.prenotificationReturn(
AchPrenotification.PrenotificationReturn.builder()
Expand Down
76 changes: 31 additions & 45 deletions increase-java-core/src/test/kotlin/com/increase/api/models/AchTransferCreateParamsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,26 +20,21 @@ class AchTransferCreateParamsTest {
.category(AchTransferCreateParams.Addenda.Category.FREEFORM)
.freeform(
AchTransferCreateParams.Addenda.Freeform.builder()
.entries(
listOf(
AchTransferCreateParams.Addenda.Freeform.Entry.builder()
.paymentRelatedInformation("x")
.build()
)
.addEntry(
AchTransferCreateParams.Addenda.Freeform.Entry.builder()
.paymentRelatedInformation("x")
.build()
)
.build()
)
.paymentOrderRemittanceAdvice(
AchTransferCreateParams.Addenda.PaymentOrderRemittanceAdvice.builder()
.invoices(
listOf(
AchTransferCreateParams.Addenda.PaymentOrderRemittanceAdvice
.Invoice
.builder()
.invoiceNumber("x")
.paidAmount(0L)
.build()
)
.addInvoice(
AchTransferCreateParams.Addenda.PaymentOrderRemittanceAdvice.Invoice
.builder()
.invoiceNumber("x")
.paidAmount(0L)
.build()
)
.build()
)
Expand Down Expand Up @@ -84,26 +79,22 @@ class AchTransferCreateParamsTest {
.category(AchTransferCreateParams.Addenda.Category.FREEFORM)
.freeform(
AchTransferCreateParams.Addenda.Freeform.builder()
.entries(
listOf(
AchTransferCreateParams.Addenda.Freeform.Entry.builder()
.paymentRelatedInformation("x")
.build()
)
.addEntry(
AchTransferCreateParams.Addenda.Freeform.Entry.builder()
.paymentRelatedInformation("x")
.build()
)
.build()
)
.paymentOrderRemittanceAdvice(
AchTransferCreateParams.Addenda.PaymentOrderRemittanceAdvice.builder()
.invoices(
listOf(
AchTransferCreateParams.Addenda.PaymentOrderRemittanceAdvice
.Invoice
.builder()
.invoiceNumber("x")
.paidAmount(0L)
.build()
)
.addInvoice(
AchTransferCreateParams.Addenda.PaymentOrderRemittanceAdvice
.Invoice
.builder()
.invoiceNumber("x")
.paidAmount(0L)
.build()
)
.build()
)
Expand Down Expand Up @@ -146,26 +137,21 @@ class AchTransferCreateParamsTest {
.category(AchTransferCreateParams.Addenda.Category.FREEFORM)
.freeform(
AchTransferCreateParams.Addenda.Freeform.builder()
.entries(
listOf(
AchTransferCreateParams.Addenda.Freeform.Entry.builder()
.paymentRelatedInformation("x")
.build()
)
.addEntry(
AchTransferCreateParams.Addenda.Freeform.Entry.builder()
.paymentRelatedInformation("x")
.build()
)
.build()
)
.paymentOrderRemittanceAdvice(
AchTransferCreateParams.Addenda.PaymentOrderRemittanceAdvice.builder()
.invoices(
listOf(
AchTransferCreateParams.Addenda.PaymentOrderRemittanceAdvice
.Invoice
.builder()
.invoiceNumber("x")
.paidAmount(0L)
.build()
)
.addInvoice(
AchTransferCreateParams.Addenda.PaymentOrderRemittanceAdvice.Invoice
.builder()
.invoiceNumber("x")
.paidAmount(0L)
.build()
)
.build()
)
Expand Down
68 changes: 27 additions & 41 deletions increase-java-core/src/test/kotlin/com/increase/api/models/AchTransferTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,27 +26,21 @@ class AchTransferTest {
.category(AchTransfer.Addenda.Category.FREEFORM)
.freeform(
AchTransfer.Addenda.Freeform.builder()
.entries(
listOf(
AchTransfer.Addenda.Freeform.Entry.builder()
.paymentRelatedInformation(
"payment_related_information"
)
.build()
)
.addEntry(
AchTransfer.Addenda.Freeform.Entry.builder()
.paymentRelatedInformation("payment_related_information")
.build()
)
.build()
)
.paymentOrderRemittanceAdvice(
AchTransfer.Addenda.PaymentOrderRemittanceAdvice.builder()
.invoices(
listOf(
AchTransfer.Addenda.PaymentOrderRemittanceAdvice.Invoice
.builder()
.invoiceNumber("invoice_number")
.paidAmount(0L)
.build()
)
.addInvoice(
AchTransfer.Addenda.PaymentOrderRemittanceAdvice.Invoice
.builder()
.invoiceNumber("invoice_number")
.paidAmount(0L)
.build()
)
.build()
)
Expand Down Expand Up @@ -108,17 +102,14 @@ class AchTransferTest {
.individualId(null)
.individualName("Ian Crease")
.network(AchTransfer.Network.ACH)
.notificationsOfChange(
listOf(
AchTransfer.NotificationsOfChange.builder()
.changeCode(
AchTransfer.NotificationsOfChange.ChangeCode
.INCORRECT_ACCOUNT_NUMBER
)
.correctedData("32")
.createdAt(OffsetDateTime.parse("2020-01-31T23:59:59Z"))
.build()
)
.addNotificationsOfChange(
AchTransfer.NotificationsOfChange.builder()
.changeCode(
AchTransfer.NotificationsOfChange.ChangeCode.INCORRECT_ACCOUNT_NUMBER
)
.correctedData("32")
.createdAt(OffsetDateTime.parse("2020-01-31T23:59:59Z"))
.build()
)
.pendingTransactionId(null)
.preferredEffectiveDate(
Expand Down Expand Up @@ -178,25 +169,20 @@ class AchTransferTest {
.category(AchTransfer.Addenda.Category.FREEFORM)
.freeform(
AchTransfer.Addenda.Freeform.builder()
.entries(
listOf(
AchTransfer.Addenda.Freeform.Entry.builder()
.paymentRelatedInformation("payment_related_information")
.build()
)
.addEntry(
AchTransfer.Addenda.Freeform.Entry.builder()
.paymentRelatedInformation("payment_related_information")
.build()
)
.build()
)
.paymentOrderRemittanceAdvice(
AchTransfer.Addenda.PaymentOrderRemittanceAdvice.builder()
.invoices(
listOf(
AchTransfer.Addenda.PaymentOrderRemittanceAdvice.Invoice
.builder()
.invoiceNumber("invoice_number")
.paidAmount(0L)
.build()
)
.addInvoice(
AchTransfer.Addenda.PaymentOrderRemittanceAdvice.Invoice.builder()
.invoiceNumber("invoice_number")
.paidAmount(0L)
.build()
)
.build()
)
Expand Down
66 changes: 33 additions & 33 deletions ...-java-core/src/test/kotlin/com/increase/api/models/BookkeepingEntrySetCreateParamsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,17 @@ class BookkeepingEntrySetCreateParamsTest {
@Test
fun createBookkeepingEntrySetCreateParams() {
BookkeepingEntrySetCreateParams.builder()
.entries(
listOf(
BookkeepingEntrySetCreateParams.Entry.builder()
.accountId("bookkeeping_account_9husfpw68pzmve9dvvc7")
.amount(100L)
.build(),
BookkeepingEntrySetCreateParams.Entry.builder()
.accountId("bookkeeping_account_t2obldz1rcu15zr54umg")
.amount(-100L)
.build()
)
.addEntry(
BookkeepingEntrySetCreateParams.Entry.builder()
.accountId("bookkeeping_account_9husfpw68pzmve9dvvc7")
.amount(100L)
.build()
)
.addEntry(
BookkeepingEntrySetCreateParams.Entry.builder()
.accountId("bookkeeping_account_t2obldz1rcu15zr54umg")
.amount(-100L)
.build()
)
.date(OffsetDateTime.parse("2020-01-31T23:59:59Z"))
.transactionId("transaction_uyrp7fld2ium70oa7oi")
Expand All @@ -32,17 +32,17 @@ class BookkeepingEntrySetCreateParamsTest {
fun getBody() {
val params =
BookkeepingEntrySetCreateParams.builder()
.entries(
listOf(
BookkeepingEntrySetCreateParams.Entry.builder()
.accountId("bookkeeping_account_9husfpw68pzmve9dvvc7")
.amount(100L)
.build(),
BookkeepingEntrySetCreateParams.Entry.builder()
.accountId("bookkeeping_account_t2obldz1rcu15zr54umg")
.amount(-100L)
.build()
)
.addEntry(
BookkeepingEntrySetCreateParams.Entry.builder()
.accountId("bookkeeping_account_9husfpw68pzmve9dvvc7")
.amount(100L)
.build()
)
.addEntry(
BookkeepingEntrySetCreateParams.Entry.builder()
.accountId("bookkeeping_account_t2obldz1rcu15zr54umg")
.amount(-100L)
.build()
)
.date(OffsetDateTime.parse("2020-01-31T23:59:59Z"))
.transactionId("transaction_uyrp7fld2ium70oa7oi")
Expand Down Expand Up @@ -70,17 +70,17 @@ class BookkeepingEntrySetCreateParamsTest {
fun getBodyWithoutOptionalFields() {
val params =
BookkeepingEntrySetCreateParams.builder()
.entries(
listOf(
BookkeepingEntrySetCreateParams.Entry.builder()
.accountId("bookkeeping_account_9husfpw68pzmve9dvvc7")
.amount(100L)
.build(),
BookkeepingEntrySetCreateParams.Entry.builder()
.accountId("bookkeeping_account_t2obldz1rcu15zr54umg")
.amount(-100L)
.build()
)
.addEntry(
BookkeepingEntrySetCreateParams.Entry.builder()
.accountId("bookkeeping_account_9husfpw68pzmve9dvvc7")
.amount(100L)
.build()
)
.addEntry(
BookkeepingEntrySetCreateParams.Entry.builder()
.accountId("bookkeeping_account_t2obldz1rcu15zr54umg")
.amount(-100L)
.build()
)
.build()
val body = params.getBody()
Expand Down
26 changes: 13 additions & 13 deletions increase-java-core/src/test/kotlin/com/increase/api/models/BookkeepingEntrySetTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,19 @@ class BookkeepingEntrySetTest {
.id("bookkeeping_entry_set_n80c6wr2p8gtc6p4ingf")
.createdAt(OffsetDateTime.parse("2023-02-11T02:11:59Z"))
.date(OffsetDateTime.parse("2020-01-31T23:59:59Z"))
.entries(
listOf(
BookkeepingEntrySet.Entry.builder()
.id("bookkeeping_entry_ctjpajsj3ks2blx10375")
.accountId("bookkeeping_account_e37p1f1iuocw5intf35v")
.amount(1750L)
.build(),
BookkeepingEntrySet.Entry.builder()
.id("bookkeeping_entry_ctjpajsj3ks2blx10375")
.accountId("bookkeeping_account_e37p1f1iuocw5intf35v")
.amount(-1750L)
.build()
)
.addEntry(
BookkeepingEntrySet.Entry.builder()
.id("bookkeeping_entry_ctjpajsj3ks2blx10375")
.accountId("bookkeeping_account_e37p1f1iuocw5intf35v")
.amount(1750L)
.build()
)
.addEntry(
BookkeepingEntrySet.Entry.builder()
.id("bookkeeping_entry_ctjpajsj3ks2blx10375")
.accountId("bookkeeping_account_e37p1f1iuocw5intf35v")
.amount(-1750L)
.build()
)
.idempotencyKey(null)
.transactionId(null)
Expand Down
6 changes: 3 additions & 3 deletions increase-java-core/src/test/kotlin/com/increase/api/models/CardDisputeListParamsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class CardDisputeListParamsTest {
.limit(1L)
.status(
CardDisputeListParams.Status.builder()
.in_(listOf(CardDisputeListParams.Status.In.PENDING_REVIEWING))
.addIn(CardDisputeListParams.Status.In.PENDING_REVIEWING)
.build()
)
.build()
Expand All @@ -48,7 +48,7 @@ class CardDisputeListParamsTest {
.limit(1L)
.status(
CardDisputeListParams.Status.builder()
.in_(listOf(CardDisputeListParams.Status.In.PENDING_REVIEWING))
.addIn(CardDisputeListParams.Status.In.PENDING_REVIEWING)
.build()
)
.build()
Expand All @@ -64,7 +64,7 @@ class CardDisputeListParamsTest {
expected.put("idempotency_key", "x")
expected.put("limit", "1")
CardDisputeListParams.Status.builder()
.in_(listOf(CardDisputeListParams.Status.In.PENDING_REVIEWING))
.addIn(CardDisputeListParams.Status.In.PENDING_REVIEWING)
.build()
.forEachQueryParam { key, values -> expected.put("status.$key", values) }
assertThat(params.getQueryParams()).isEqualTo(expected.build())
Expand Down
Loading