Rename Suggestion.simple(String) to Suggestion.suggestion(String) #695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plan is to also change the static factories on (Component)TooltipSuggestion to be called suggestion. This makes static imports much cleaner when creating a variety of suggestions with and without tooltips for example.
Citymonstret
approved these changes
Feb 24, 2024
jpenilla
added a commit
that referenced
this pull request
Feb 24, 2024
* Add back configurable suggestion mapper to command manager this is useful for more easily implementing a ComponentTooltipSuggestion, for example * remove final * adjust MappingSuggestionFactory#mapped * Apply suggestion mappers before suggestion processors. * SuggestionProcessor#and -> #then * Rename Suggestion.simple(String) to Suggestion.suggestion(String) (#695) The plan is to also change the static factories on (Component)TooltipSuggestion to be called suggestion. This makes static imports much cleaner when creating a variety of suggestions with and without tooltips for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plan is to also change the static factories on (Component)TooltipSuggestion to be called suggestion. This makes static imports much cleaner when creating a variety of suggestions with and without tooltips for example.