fix(bukkit): create registry ResourceKey directly #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously they were fetched from registry instances which are harder to obtain. Now it just creates them using the static methods available on ResourceKey.
broccolai
approved these changes
Aug 19, 2024
Member
|
Have you checked that this will still work back to 1.19.3? |
Contributor
Author
I looked at the mappings for older versions and the createRegistryKey method has existed for a while, and always been obfuscated to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously they were fetched from registry instances which are harder to obtain. Now it just creates them using the static methods available on ResourceKey.
Added an example command that uses the parser in question to show it now works.
Fixes #95