feat(minecraft-extras): ComponentParser #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a parser for adventure components using a provided ComponentDecoder. Requries an adventure version bump to 4.16 for the ComponentDecoder interface.
Contributor
Author
|
Implemented the brig mapping contributor mapping the ComponentParser to the brig string type based on the StringMode provided. Also reverted the adventure version bump to not break compat. |
jpenilla
reviewed
Mar 23, 2024
jpenilla
reviewed
Mar 23, 2024
Member
|
Still needs a ParserContributor, not sure how we want to handle selecting a serializer from annotations though. It should also check the string greedy/quoted annotations. |
Contributor
Author
|
Ok, add a ParserContributor and annotations to configure the ComponentParser |
jpenilla
reviewed
Mar 24, 2024
...-extras/src/main/java/org/incendo/cloud/minecraft/extras/MinecraftExtraParserParameters.java
Outdated
Show resolved
Hide resolved
...tras/src/main/java/org/incendo/cloud/minecraft/extras/parser/ComponentParserContributor.java
Show resolved
Hide resolved
jpenilla
reviewed
Mar 24, 2024
jpenilla
reviewed
Mar 24, 2024
jpenilla
reviewed
Mar 24, 2024
cloud-minecraft-extras/src/main/java/org/incendo/cloud/minecraft/extras/annotation/Decoder.java
Outdated
Show resolved
Hide resolved
jpenilla
reviewed
Mar 25, 2024
.../main/java/org/incendo/cloud/examples/bukkit/builder/feature/minecraft/ComponentExample.java
Show resolved
Hide resolved
jpenilla
changed the title
jpenilla
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a parser for adventure components using a provided ComponentDecoder. ~~Requries an adventure version bump to 4.16 for the ComponentDecoder interface.~~reverted
Currently I have the default StringMode to QUOTED for the static factory methods that don't take a StringMode parameter. Unsure if that's the best, but I don't think SINGLE is the best option as these can regularly be expected to contain spaces.
Remade from Incendo/cloud#447