[Fixes #129] Fix warning about using the PlayerSpawnLocationEvent on Paper #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergerkiller
changed the title
bergerkiller
force-pushed
the
fixEventWarning
branch
from
807e499 to
5a64f35
Compare
Contributor
Author
|
After a short discussion Ive simplified the PR a lot by just using the pre login event instead, which is available back in bukkit 1.8. |
jpenilla
requested changes
Oct 11, 2025
cloud-bukkit/src/main/java/org/incendo/cloud/bukkit/CloudBukkitListener.java
Show resolved
Hide resolved
jpenilla
requested changes
Oct 11, 2025
cloud-bukkit/src/main/java/org/incendo/cloud/bukkit/CloudBukkitListener.java
Outdated
Show resolved
Hide resolved
Member
|
Ignoring my apparent struggle with the GH ui, looks good but the comment needs updating |
bergerkiller
force-pushed
the
fixEventWarning
branch
from
5a64f35 to
b1d55ff
Compare
Contributor
Author
|
Pushed the comment fix. Sorry for delay, I was busy elsewhere |
jpenilla
reviewed
Oct 11, 2025
cloud-bukkit/src/main/java/org/incendo/cloud/bukkit/CloudBukkitListener.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Irmo van den Berge <irmo.vandenberge@mailbox.org>
bergerkiller
force-pushed
the
fixEventWarning
branch
from
b1d55ff to
1ae1b19
Compare
jpenilla
approved these changes
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made use of the single-event registration API of Bukkit to avoid having to add a submodule for paper.
Tested it locally and works without warnings or errors now.
Fixes #129