Skip to content
This repository was archived by the owner on Dec 23, 2024. It is now read-only.

added zerolog shim #3

Merged
merged 4 commits into from
Aug 10, 2018
Merged

added zerolog shim #3

merged 4 commits into from
Aug 10, 2018

Conversation

schigh
Copy link
Contributor

@schigh schigh commented Aug 3, 2018

Added the shim for zerolog w/tests

@codecov
Copy link

codecov bot commented Aug 6, 2018

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #3   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      5    +1     
  Lines         148    195   +47     
=====================================
+ Hits          148    195   +47
Impacted Files Coverage Δ
shims/zerolog/zerolog.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 578aa5e...5065abb. Read the comment docs.

Copy link
Contributor

@dselans dselans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the README to mention that there's a zerolog implementation as well?

Copy link
Contributor

@dselans dselans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update README.md w/ mention of zerolog.

@schigh
Copy link
Contributor Author

schigh commented Aug 6, 2018

@dselans should be good to go now

Copy link
Contributor

@dselans dselans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeeeeet!

@dselans dselans merged commit c377c6c into InVisionApp:master Aug 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants