Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ci 3.9 #67

Merged
merged 3 commits into from
Aug 26, 2022
Merged

Feature/ci 3.9 #67

merged 3 commits into from
Aug 26, 2022

Conversation

jacobcook1995
Copy link
Collaborator

Description

Changes the build check section of the continuous integration to use python version 3.9.

Fixes #66

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@davidorme davidorme merged commit 0276ee8 into develop Aug 26, 2022
@jacobcook1995 jacobcook1995 deleted the feature/ci_3.9 branch August 26, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidorme davidorme davidorme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Github actions mypy build check fails when python 3.9 typing is used
2 participants
@jacobcook1995 @davidorme