-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding design notes on core data setup and configuration #65
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #65 +/- ##
========================================
Coverage 75.86% 75.86%
========================================
Files 3 3
Lines 58 58
========================================
Hits 44 44
Misses 14 14 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a couple of comments, also am wondering whether this actually should close issue #64, which it currently will automatically when merged
That's a good point about closing - I intended the issue just to provide the proposal for discussion, but it might as well serve to cover the implementation. This would have been better as a GH discussion! |
configuring the data generator with a set random number generator seed. | ||
|
||
These could get arbitrarily complex - so at some point we should just say, if you want | ||
sufficiently complex generated data, just roll your own NetCDF files! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please explain this a bit more? When would this apply?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard to define! But if someone wanted to simulate a scenario of 5 drought years followed by 3 years of elevated rainfall then an El Niño and then a plague of frogs - that's probably outside the scope 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good, clear starting point to design the core set up and config.
Maybe we can start a discussion for more details on data inputs types/format and grid shapes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding examples and clarification ( I'm just making sure it's idiot proof ;-) ). I think the document is very clear now, ready to merge from my point of view 👍
This pull request provides a proposal for the data initialisation process.
Fixes #64
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks