-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving how excrement and carcass decay is handled #562
Merged
jacobcook1995
merged 11 commits into
develop
from
546-improve-how-excrement-and-carcass-decay-is-handled
Sep 17, 2024
Merged
Improving how excrement and carcass decay is handled #562
jacobcook1995
merged 11 commits into
develop
from
546-improve-how-excrement-and-carcass-decay-is-handled
Sep 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r than energy terms
…s after predation
…d added nitrogen and phosphorus flows in
…ion used at initialisation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #562 +/- ##
===========================================
+ Coverage 94.95% 95.01% +0.05%
===========================================
Files 74 74
Lines 4186 4235 +49
===========================================
+ Hits 3975 4024 +49
Misses 211 211 ☔ View full report in Codecov by Sentry. |
TaranRallings
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! (weeping softly at my desk)
jacobcook1995
deleted the
546-improve-how-excrement-and-carcass-decay-is-handled
branch
September 17, 2024 14:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does three things:
The excrement and carcass decay flows from the animal model don't actually link to anything at the moment, I'll make an issue to track this, and then fix this when I'm back working on the
soil
model.Fixes #510
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks