-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
519 review abiotic simple and hydrology docstrings to match updated documentation #521
519 review abiotic simple and hydrology docstrings to match updated documentation #521
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #521 +/- ##
===========================================
- Coverage 94.93% 94.93% -0.01%
===========================================
Files 73 73
Lines 4050 4048 -2
===========================================
- Hits 3845 3843 -2
Misses 205 205 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, apart from the breaking tests.
"cell_id": self.grid.cell_id, | ||
}, | ||
) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing that it's this change that's causing the tests to break on windows?
…ocstrings-to-match-updated-documentation
This PR updates the docstrings for the
abiotic_simple
andhydrology
models. Nothing major, only a few bits that were outdated or inconsistent.Also, I (was trying to) get rid of the variables that are initialized but not needed in the
hydrology
model. This led to an old problem of random model order on Windows which caused some tests to fail. The change needs to be postponed until the variables system is up and running, see #522Fixes #519
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks