-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
490 hydrology docs on implementation #518
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #518 +/- ##
========================================
Coverage 94.93% 94.93%
========================================
Files 73 73
Lines 4048 4048
========================================
Hits 3843 3843
Misses 205 205 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! I just had a minor LaTeX suggestion
docs/source/virtual_ecosystem/implementation/hydrology_implementation.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - some minor issues.
This PR adds the implementation of the hydrology model and updates the variables description in the abiotic simple model to match the plants.
There is a problem with loading the elevation data from netcdf, I'll try and figure that out soon.
https://virtual-ecosystem.readthedocs.io/en/490-hydrology-docs-on-implementation/virtual_ecosystem/implementation/hydrology_implementation.html
Fixes #490
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks