Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

490 hydrology docs on implementation #518

Merged
merged 15 commits into from
Jul 16, 2024

Conversation

vgro
Copy link
Collaborator

@vgro vgro commented Jul 15, 2024

This PR adds the implementation of the hydrology model and updates the variables description in the abiotic simple model to match the plants.
There is a problem with loading the elevation data from netcdf, I'll try and figure that out soon.

https://virtual-ecosystem.readthedocs.io/en/490-hydrology-docs-on-implementation/virtual_ecosystem/implementation/hydrology_implementation.html

Fixes #490

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@vgro vgro linked an issue Jul 15, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.93%. Comparing base (fb2fea3) to head (6eb3ecd).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #518   +/-   ##
========================================
  Coverage    94.93%   94.93%           
========================================
  Files           73       73           
  Lines         4048     4048           
========================================
  Hits          3843     3843           
  Misses         205      205           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! I just had a minor LaTeX suggestion

Copy link
Collaborator

@davidorme davidorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - some minor issues.

@vgro vgro merged commit 864a5c4 into develop Jul 16, 2024
12 checks passed
@vgro vgro deleted the 490-hydrology-docs-on-implementation branch July 16, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydrology - Docs on implementation
4 participants