Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved _feature function to top level #51

Merged
merged 5 commits into from
Jul 29, 2022
Merged

Moved _feature function to top level #51

merged 5 commits into from
Jul 29, 2022

Conversation

robewers01
Copy link
Contributor

Description

Moved _feature out of export_geojson

Fixes #29

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

N/A

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

N/A

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@davidorme davidorme mentioned this pull request Jul 29, 2022
7 tasks
@davidorme davidorme merged commit 4d56969 into develop Jul 29, 2022
@davidorme davidorme deleted the toplevel branch July 29, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make internal function top level
3 participants