-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt extended LayerStructure functionality #459
Adopt extended LayerStructure functionality #459
Conversation
…into 458-adopt-extended-layerstructure-functionality
…into 458-adopt-extended-layerstructure-functionality
…into 458-adopt-extended-layerstructure-functionality
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #459 +/- ##
===========================================
- Coverage 94.96% 94.95% -0.01%
===========================================
Files 70 70
Lines 3792 3869 +77
===========================================
+ Hits 3601 3674 +73
- Misses 191 195 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (though I only looked at the soil related stuff)!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a few comments that are probably for another PR.
Description
This PR is taking the code in
develop
and applying the new API for the LayerStructure from #452, which has been merged down into this.The main changes are:
LayerStructure
indices.LayerStructure.role_indices['canopy']
approach from the first pass in Amending vertical layer structure #441, which has been deprecated in favour of explicit per role attributes (LayerStructure.index_canopy
).fixture_core_components
and then systematically using thefrom_template
and index attributes to generate expected and test values, replacing hard coded integer layer indices with layer specific indices from thefixture_core_components.LayerStructure
instance.Fixes #451 and #458
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks