-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the demo run to the website pages #428
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #428 +/- ##
===========================================
+ Coverage 94.52% 94.68% +0.16%
===========================================
Files 70 70
Lines 3744 3744
===========================================
+ Hits 3539 3545 +6
+ Misses 205 199 -6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Only comment is that it isn't as engrossing as the live demo as it doesn't run while you watch it, but I'm guessing that isn't straightforward to setup the docs to do.
Yeah - there's no way to generate this dynamically on request. We'd need a live |
Yeah that definitely feels like overkill for this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, a few small comments regarding the input data.
I think it's probably as simple as using Binder? https://mybinder.org/ |
Co-authored-by: vgro <44095758+vgro@users.noreply.github.com>
Description
This adds a new page to the docs that contains the current simple walkthrough of running the model. It fixes a couple of minor
sphinx
issues along the way.See: https://virtual-ecosystem.readthedocs.io/en/426-add-a-demo-run-to-the-website-pages/virtual_ecosystem/virtual_ecosystem_in_use.html
Closes #426
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks