-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/juvenile dispersal - Adding juvenile dispersal to the Animal Module #419
Conversation
…ood was available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've a couple of comments related to the naming or interpretation of the probability. But otherwise looks good.
… and changed related calls and tests.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #419 +/- ##
===========================================
+ Coverage 94.59% 94.62% +0.02%
===========================================
Files 69 69
Lines 3648 3666 +18
===========================================
+ Hits 3451 3469 +18
Misses 197 197 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of suggestions for the probability part, but looks good otherwise.
Co-authored-by: Diego Alonso Álvarez <6095790+dalonsoa@users.noreply.github.com>
Co-authored-by: Diego Alonso Álvarez <6095790+dalonsoa@users.noreply.github.com>
…ialCollegeLondon/virtual_rainforest into feature/juvenile_dispersal
Description
Following Madingley, this builds on previous starvation-induced dispersal to add a dispersal check immediately after a cohort is born. When migrate_community is called during the normal flow of model execution there is a secondary check to see if the cohort is newly created. If the cohort is new, it creates a probability of dispersal based on allometric movement speed and grid size.
Currently, this only works for 'rook move' dispersal. The logic can be expanded for diagonal movement and multi-grid occupancy but we can leave that for a little later.
Fixes # (issue)
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks