Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defining the CoreComponents, LayerStructure and ModelTiming classes #374

Merged
merged 40 commits into from
Feb 5, 2024
Merged
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
685e42b
Draft implementation of CoreComponents
davidorme Jan 24, 2024
f5f6a20
Doc fixes
davidorme Jan 24, 2024
4a70211
Forgot to add new tests file
davidorme Jan 24, 2024
01fc628
Extending and fixing tests
davidorme Jan 24, 2024
9513801
Updating callable signatures to use CoreComponents - not unpacked yet.
davidorme Jan 25, 2024
45ac49a
Updating main to use CoreComponents
davidorme Jan 25, 2024
9a76bba
Unpacking core components into new BaseModel attributes
davidorme Jan 25, 2024
548c849
Revising docstrings
davidorme Jan 25, 2024
adaf95b
MoarRevising docstrings
davidorme Jan 25, 2024
b96e68e
Updating Plants Model
davidorme Jan 25, 2024
be73d57
Updating soils model
davidorme Jan 25, 2024
9f2c892
Updating litter model
davidorme Jan 25, 2024
42d8bbc
Updated hydrology_model
davidorme Jan 25, 2024
53153fd
Updated abiotic_simple_model
davidorme Jan 25, 2024
a5cd8bd
Added n_layers to LayerStructure
davidorme Jan 25, 2024
4359c6e
Use n_layers in models
davidorme Jan 25, 2024
03b5a81
Updated animal model
davidorme Jan 25, 2024
e17e368
Converted layer_roles from tuple to list - incompatible with xarray c…
davidorme Jan 25, 2024
f862264
AnimalModel loads wrong constants
davidorme Jan 25, 2024
b02d14a
Added Config and CoreComponents fixtures, updated fixtures using prev…
davidorme Jan 25, 2024
242fe2f
Removing test for deprecated extract_timing_details
davidorme Jan 25, 2024
e3c33a7
Updating plants tests to new BaseModel structure
davidorme Jan 25, 2024
086e53f
Potential solution to BaseModel._repr issue
davidorme Jan 25, 2024
a705be0
Updating soil tests
davidorme Jan 25, 2024
5d55541
Update litter model tests
davidorme Jan 25, 2024
388fc9f
Updating hydrology model tests
davidorme Jan 26, 2024
86c4c93
Updated abiotic_simple model tests
davidorme Jan 26, 2024
cb048e8
Restored BaseModel._check_update_speed functionality
davidorme Jan 26, 2024
e3181e9
Fixing core tests, log message tweaks
davidorme Jan 26, 2024
663d3c4
Deprecated input file location in tests
davidorme Jan 26, 2024
ce3396b
Updating animal model tests
davidorme Jan 26, 2024
127423e
Last test fixes
davidorme Jan 26, 2024
b1c9339
Cleaner start_time setting
davidorme Jan 26, 2024
53d820f
add _validate_canopy_layer function
davidorme Jan 26, 2024
849e651
add _validate_soil_layers function
davidorme Jan 26, 2024
162daa4
Updating core_component.py validators and adding unit tests for valid…
davidorme Jan 26, 2024
20fe796
Merge pull request #375 from ImperialCollegeLondon/369-adopting-new-core
davidorme Feb 2, 2024
42bd787
Indenting issue in RST
davidorme Feb 2, 2024
7443127
Fixing docstring issues
davidorme Feb 5, 2024
b4fb178
Merge branch 'develop' into 369-simplifying-the-model-creation-setup
davidorme Feb 5, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'develop' into 369-simplifying-the-model-creation-setup
  • Loading branch information
davidorme committed Feb 5, 2024
commit b4fb178873cd5f7f314cc4d25b7d3114cef43bee
8 changes: 5 additions & 3 deletions docs/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,11 @@ class MyReferenceStyle(AuthorYearReferenceStyle):
("py:class", "numpy.int64"),
("py:class", "numpy.float32"),
# HACK - core_components docstrings are being odd.
# ("py:class", "np.timedelta64"),
# ("py:class", "np.datetime64"),
# ("py:class", "InitVar"),
("py:class", "np.timedelta64"),
("py:class", "np.datetime64"),
("py:class", "InitVar"),
("py:class", "Quantity"),
("py:class", "numpy._typing._array_like._ScalarType_co"),
# TODO - Delete this once Vivienne has merged this feature into develop
("py:class", "virtual_rainforest.models.abiotic.energy_balance.EnergyBalance"),
# Something off about JSONSchema intersphinx mapping?
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.