-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft high level function to setup and run simulation #112
Conversation
Adding in new model api details from develop
Adding in CI changes from develop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main structure looks good - some thoughts about where errors get raised and a minor point about string formatting in logging
Codecov Report
@@ Coverage Diff @@
## develop #112 +/- ##
===========================================
+ Coverage 95.90% 96.38% +0.48%
===========================================
Files 9 10 +1
Lines 366 415 +49
===========================================
+ Hits 351 400 +49
Misses 15 15
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As usual, I've reviewed the new code and will work on the tests once this is sorted out.
Good first attempt as having something that runs!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Nothing more to add!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description
I've written a draft of the high level function to setup and run the
virtual_rainforest
model. Most of this function is just a set of TODOs at the moment, but config validation and model configuration is currently performed. This involved defining functions to extract the models to be configured from the config object, and to actually configure a set of models which can then be used downstream.While doing this I also changed error handling a bit to ensure that the user is provided with the maximum amount of useful information, e.g. report all models that fail to configure before ending the process, and reporting all schema validation errors rather than just the first.
Fixes #98
Fixes #100
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks