Uploading plant functional type species classification base R script #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidorme
requested changes
Mar 19, 2025
analaysis/plant/plant_functional_types/plant_functional_type_species_classification_base.R
Outdated
Show resolved
Hide resolved
analaysis/plant/plant_functional_types/plant_functional_type_species_classification_base.R
Outdated
Show resolved
Hide resolved
analaysis/plant/plant_functional_types/plant_functional_type_species_classification_base.R
Outdated
Show resolved
Hide resolved
davidorme
reviewed
Mar 20, 2025
analaysis/plant/plant_functional_type/plant_functional_type_species_classification_base.R
Outdated
Show resolved
Hide resolved
analaysis/plant/plant_functional_type/plant_functional_type_species_classification_base.R
Show resolved
Hide resolved
arne-exe
requested review from
davidorme and
annarallings
and removed request for
davidorme
|
Hi @davidorme, could you please approve the pull request. The requested changes were made but I think your approval of these changes are the final thing preventing the merge (even when Anna has approved the pull request). Could you also please explain if this is indeed the correct way (i.e., if a reviewer requests changes they HAVE to explicitly approve it again before the pull request can be merged)? |
|
Have these changes been made to your satisfaction @davidorme? |
|
Issue #22 can now be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is linked to #22 and uploads the plant functional type species classification base R script to the analysis folder.