-
Notifications
You must be signed in to change notification settings - Fork 0
Upload VE Climate Data Preparation Script #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
Could you please review it and check the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! I added a few points to update, but happy for you to merge this when the checks are successful
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@lelavathy I've now merged #86 so the |
@davidorme I have moved this file to analysis/abiotic. Basically, I have merged part of code from maliau_era5_download_reproject into my climate processing script. @vgro could you please review the merged script? |
|
||
# Use the rasterio accessor tools to reproject the data | ||
|
||
# NOTE: The reprojection is automatically applying downscaling to the 90m grid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't call this downscaling here, it's really just an interpolation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidorme I think we can delete this maliau_era5_download_and_reproject script. I have already integrated this script into maliau_climate_data_processing_script.
# | ||
# https://rasterio.readthedocs.io/en/stable/api/rasterio.enums.html#rasterio.enums.Resampling | ||
# | ||
# We might want to use a different interpolation strategy to give a smooth surface - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part could be replaced with the comment you made in the other script about downscaling in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with @vgro requested changes
This issue is to upload and integrate a Python script that prepares ERA5-Land climate data for the Virtual Ecosystem (VE) model. The script:
Additional Notes:
numpy
,xarray
,tomllib
, andpyproj
.x
,y
, andtime_index
dimensions.This issue will serve as a reference for uploading, testing, and documenting the VE climate data preparation workflow.
Fixes #105