-
Notifications
You must be signed in to change notification settings - Fork 0
102 rethinking litter decay models #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ete litter nutrient data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, I'd avoid loading this data in GitHub (though it is really small)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@annarallings this dataset is extracted from a figure (which is considered "primary"), so I save the extracted data as "derived". We haven't decided yet, but the current feeling is to avoid pushing primary data at all (meaning the folder will probably be removed entirely). However, I am not 100% sure about derived data like this. Do you want me to treat it more like a primary data and not push it (use Globus) instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple comments on documentation and data - looks good otherwise.
This can be merged once #108 is merged. |
This PR updates a previous analysis merged via #70 to better improve parameter estimation. When I say "improve" it is hard to say what has improved, because we really don't know what the expected values are. BUT, I think we can say that the improvement is in making sure that the fitted models are not as biased / sensitive to our prior choice (I think previously they were, as described in #102 .
What I did:
Then using average leaf and wood lignin from @arne-exe 's plant stoichiometry script, I recovered$s_N = s'_N / L_\text{leaf}$ , $s_P = s'_P / L_\text{leaf}$ , $k_s = K(L) / \exp(-r L_\text{leaf})$ , and $k_w = K_W / \exp(-r L_\text{wood})$ . Assigning average leaf and wood lignin to everything will be a crude assumption that we need to accept at this stage.
I am setting this PR as a draft because I want to test it out on #101 and check if we still get crazy equilibrium values.