-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pip support #175
Add pip support #175
Conversation
Hi David, Thank you very much for taking the effort and adding this to SHARPy, it will be a great addition that will make things a lot easier. I'll go through it over the next few days and comment here or commit directly to the branch if I see anything. Again, many thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally got around to reviewing and updating this, apologies and many thanks for adding this feature, @DavidAnderegg!!
All looks good, I added minor things and restored a data file that was lost thanks to gitignore I assume.
Branch updated with the latest development branch that includes the automated unittests as a Github action that are also passing.
Otherwise status check left pending and unable to merge
Overview
As promised in #171 this PR makes SHARPy installable via pip. After building and testing, you simply install it in the current anaconda environment by running
pip install .
. This copies all necessary files into the environment and makes the commandsharpy
globally available (as long as the anaconda environment is activated).If you are developing SHARPy, you can install it in development mode with this command:
pip install -e .
. This creates only a link to the location of the SHARPy files and allows "live editing" of its source while still having all the other benefits. More about it here.Changes
setup.py
which handles the install procedure (you might want to make sure I entered the proper information)__version__
variable tosharpy.__init__.py
. This tells the setup the current version of the library and has to be changed manually before a new releasecases
folder intosharpy/cases
. This way it becomes part of thesharpy
package itself. I guess this is the most controversial change I am proposing. But it is a lot cleaner and makes life easier (the examples can be imported everywhere viasharpy.cases....
). One could argue that it should not be part of the library as it does not really provide functionality. But I have seen this in the past (for example here) and I believe the benefits are worth it. What do you think?from sharpy.cases.templates import ...
)bin
directory and its contentsharpy_run()
tosharpy_main.py
which gets executed whenever you callsharpy
in the console. It is basically the same asbin/sharpy
wassharpy_vars.sh
General Notes
nonlinear_t-tail_HALE.ipynb
because i moved thecases
folder. Maybe you can fix it? All the other examples seem to work.I am quite sure i broke something it did not think about. Please test it and let me know what you think. Feel free to commit to my branch.