Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloads badge #388

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Downloads badge #388

merged 1 commit into from
Mar 19, 2025

Conversation

barneydobson
Copy link
Collaborator

Description

Am having to give a presentation so I thought I'd include this... seems way higher than I thought - did I do it right?

Fixes # (issue)

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@barneydobson barneydobson requested a review from dalonsoa March 19, 2025 13:43
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.05%. Comparing base (80cfc4b) to head (e2dbd58).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #388   +/-   ##
=======================================
  Coverage   88.05%   88.05%           
=======================================
  Files          22       22           
  Lines        2243     2243           
  Branches      282      282           
=======================================
  Hits         1975     1975           
  Misses        191      191           
  Partials       77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

PyPI is cached in multiple places, so this number often reflects that rather than actual individuals trying to get the tool.

@barneydobson barneydobson merged commit 5c92850 into main Mar 19, 2025
5 checks passed
@barneydobson barneydobson deleted the downloads_badge branch March 19, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants