Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test CLI failing on release #386

Closed
wants to merge 2 commits into from
Closed

Conversation

barneydobson
Copy link
Collaborator

Description

Please include a summary of the change and which issue is fixed (if any). Please also
include relevant motivation and context. List any dependencies that are required for
this change.

Fixes # (issue)

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@barneydobson
Copy link
Collaborator Author

@dalonsoa I'm well confused - this window-latest, 3.11 run passes: https://github.com/ImperialCollegeLondon/SWMManywhere/actions/runs/13838574926/job/38719851089?pr=386 (as does the one on my local machine)

But in the github actions on release it fails (while all other ones pass), and it's not a fluke I've rerun the job heaps of times
https://github.com/ImperialCollegeLondon/SWMManywhere/actions/runs/13836464992/job/38717016257

@barneydobson
Copy link
Collaborator Author

resolved by redoing the action another day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant