Skip to content

Fixes for nk_strtod, nk_strtof, and nk_strtoi #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2024
Merged

Fixes for nk_strtod, nk_strtof, and nk_strtoi #682

merged 2 commits into from
Sep 4, 2024

Conversation

PROP65
Copy link
Contributor

@PROP65 PROP65 commented Sep 3, 2024

Removes const from endptr argument to allow it to function as intended.

/* From 1989 ANSI standard 4.10.1.4 */
double strtod(const char *nptr, char **endptr);

This should fix #678.

@RobLoach RobLoach merged commit 4373fd0 into Immediate-Mode-UI:master Sep 4, 2024
1 check passed
@PROP65 PROP65 deleted the func_fix branch September 5, 2024 05:48
@xzn xzn mentioned this pull request Sep 11, 2024
Open
@PROP65 PROP65 mentioned this pull request Feb 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WARN on char** for strtod
2 participants
@PROP65 @RobLoach