Failure to build

[revolucas]

Because of the changes made to nuklear_internal.h and src/nuklear.h in this commit: 455b404
I can't seem to build it into a shared dll without errors:

unresolved external symbol NK_COS
unresolved external symbol NK_DTOA
unresolved external symbol NK_MEMCPY
unresolved external symbol NK_MEMSET
unresolved external symbol NK_SIN

Vurtun's original repo, I have no issues. Seems like quite a few changes, in this repo, made to the single header version weren't mirrored into the separated implementation version.

[walkthetalk]

same problem, now only implement mode can be used.

[RobLoach]

Is this still an issue?

[sleeptightAnsiC]

Yes, this is still an issue.

If you try to build per each translation unit (instead of using amalgamated header), it will fail because multiple sources depend on macro definitions from src/nuklear_math.c and src/nuklear_util.c.

Not sure, if this is the same exact problem as the OP had, but it is probably also affected by the same commit.

repro

$ uname -a
Linux MAL200424 6.14.9-arch1-1 #1 SMP PREEMPT_DYNAMIC Thu, 29 May 2025 21:42:15 +0000 x86_64 GNU/Linux

$ cc --version
cc (GCC) 15.1.1 20250425

$ git clone https://github.com/Immediate-Mode-UI/Nuklear.git --recursive

$ cd Nuklear/src

$ for i in $(ls ./*.c); do echo "$i"; cc -x c -c "$i" -o "$i.o" -DNK_INCLUDE_FIXED_TYPES -DNK_INCLUDE_DEFAULT_ALLOCATOR -DNK_INCLUDE_STANDARD_IO -DNK_INCLUDE_STANDARD_VARARGS -DNK_INCLUDE_STANDARD_BOOL -DNK_INCLUDE_VERTEX_BUFFER_OUTPUT -DNK_INCLUDE_DEFAULT_FONT -DNK_INCLUDE_COMMAND_USERDATA ; done
## see results below

result

./nuklear_9slice.c
./nuklear_buffer.c
./nuklear_buffer.c: In function ‘nk_buffer_realloc’:
./nuklear_buffer.c:113:9: error: implicit declaration of function ‘NK_MEMCPY’ [-Wimplicit-function-declaration]
  113 |         NK_MEMCPY(temp, b->memory.ptr, buffer_size);
      |         ^~~~~~~~~
./nuklear_button.c
./nuklear_chart.c
./nuklear_chart.c: In function ‘nk_chart_end’:
./nuklear_chart.c:282:5: error: implicit declaration of function ‘NK_MEMSET’ [-Wimplicit-function-declaration]
  282 |     NK_MEMSET(chart, 0, sizeof(*chart));
      |     ^~~~~~~~~
./nuklear_color.c
./nuklear_color_picker.c
./nuklear_combo.c
./nuklear_context.c
./nuklear_context.c: In function ‘nk_clear’:
./nuklear_context.c:125:5: error: implicit declaration of function ‘NK_MEMSET’ [-Wimplicit-function-declaration]
  125 |     NK_MEMSET(&ctx->overlay, 0, sizeof(ctx->overlay));
      |     ^~~~~~~~~
./nuklear_contextual.c
./nuklear_draw.c
./nuklear_draw.c: In function ‘nk_draw_text’:
./nuklear_draw.c:555:5: error: implicit declaration of function ‘NK_MEMCPY’ [-Wimplicit-function-declaration]
  555 |     NK_MEMCPY(cmd->string, string, (nk_size)length);
      |     ^~~~~~~~~
./nuklear_edit.c
./nuklear_font.c
./nuklear_group.c
./nuklear_image.c
./nuklear_input.c
./nuklear_knob.c
./nuklear_knob.c: In function ‘nk_knob_behavior’:
./nuklear_knob.c:36:17: error: implicit declaration of function ‘NK_ATAN2’ [-Wimplicit-function-declaration]
   36 |         angle = NK_ATAN2(in->mouse.pos.y - origin.y, in->mouse.pos.x - origin.x) + direction_rads[zero_direction];
      |                 ^~~~~~~~
./nuklear_knob.c: In function ‘nk_draw_knob’:
./nuklear_knob.c:151:57: error: implicit declaration of function ‘NK_COS’; did you mean ‘NK_ABS’? [-Wimplicit-function-declaration]
  151 |     cursor_end.x = cursor_start.x + (half_circle_size * NK_COS(angle));
      |                                                         ^~~~~~
      |                                                         NK_ABS
./nuklear_knob.c:152:57: error: implicit declaration of function ‘NK_SIN’; did you mean ‘NK_MIN’? [-Wimplicit-function-declaration]
  152 |     cursor_end.y = cursor_start.y + (half_circle_size * NK_SIN(angle));
      |                                                         ^~~~~~
      |                                                         NK_MIN
./nuklear_layout.c
./nuklear_list_view.c
./nuklear_math.c
./nuklear_menu.c
./nuklear_page_element.c
./nuklear_panel.c
./nuklear_pool.c
./nuklear_popup.c
./nuklear_progress.c
./nuklear_property.c
./nuklear_property.c: In function ‘nk_do_property’:
./nuklear_property.c:178:13: error: implicit declaration of function ‘NK_DTOA’ [-Wimplicit-function-declaration]
  178 |             NK_DTOA(string, (double)variant->value.f);
      |             ^~~~~~~
./nuklear_property.c:238:9: error: implicit declaration of function ‘NK_MEMCPY’ [-Wimplicit-function-declaration]
  238 |         NK_MEMCPY(buffer, dst, (nk_size)*length);
      |         ^~~~~~~~~
./nuklear_scrollbar.c
./nuklear_selectable.c
./nuklear_slider.c
./nuklear_string.c
./nuklear_string.c: In function ‘nk_str_append_text_char’:
./nuklear_string.c:43:5: error: implicit declaration of function ‘NK_MEMCPY’ [-Wimplicit-function-declaration]
   43 |     NK_MEMCPY(mem, str, (nk_size)len * sizeof(char));
      |     ^~~~~~~~~
./nuklear_style.c
./nuklear_table.c
./nuklear_text.c
./nuklear_text_editor.c
./nuklear_text_editor.c: In function ‘nk_textedit_discard_undo’:
./nuklear_text_editor.c:742:13: error: implicit declaration of function ‘NK_MEMCPY’ [-Wimplicit-function-declaration]
  742 |             NK_MEMCPY(state->undo_char, state->undo_char + n,
      |             ^~~~~~~~~
./nuklear_text_editor.c: In function ‘nk_textedit_init_fixed’:
./nuklear_text_editor.c:1000:5: error: implicit declaration of function ‘NK_MEMSET’ [-Wimplicit-function-declaration]
 1000 |     NK_MEMSET(state, 0, sizeof(struct nk_text_edit));
      |     ^~~~~~~~~
./nuklear_toggle.c
./nuklear_tooltip.c
./nuklear_tree.c
./nuklear_utf8.c
./nuklear_util.c
./nuklear_vertex.c
./nuklear_vertex.c: In function ‘nk_draw_list_init’:
./nuklear_vertex.c:19:40: error: implicit declaration of function ‘NK_COS’; did you mean ‘NK_ABS’? [-Wimplicit-function-declaration]
   19 |         list->circle_vtx[i].x = (float)NK_COS(a);
      |                                        ^~~~~~
      |                                        NK_ABS
./nuklear_vertex.c:20:40: error: implicit declaration of function ‘NK_SIN’; did you mean ‘NK_MIN’? [-Wimplicit-function-declaration]
   20 |         list->circle_vtx[i].y = (float)NK_SIN(a);
      |                                        ^~~~~~
      |                                        NK_MIN
./nuklear_vertex.c: In function ‘nk_draw_vertex_color’:
./nuklear_vertex.c:287:9: error: implicit declaration of function ‘NK_MEMCPY’ [-Wimplicit-function-declaration]
  287 |         NK_MEMCPY(attr, &col.r, sizeof(col));
      |         ^~~~~~~~~
./nuklear_vertex.c: In function ‘nk_draw_list_stroke_poly_line’:
./nuklear_vertex.c:482:23: error: implicit declaration of function ‘NK_INV_SQRT’ [-Wimplicit-function-declaration]
  482 |                 len = NK_INV_SQRT(len);
      |                       ^~~~~~~~~~~
./nuklear_widget.c
./nuklear_window.c
./nuklear_window.c: In function ‘nk_begin_titled’:
./nuklear_window.c:180:9: error: implicit declaration of function ‘NK_MEMCPY’ [-Wimplicit-function-declaration]
  180 |         NK_MEMCPY(win->name_string, name, name_length);
      |         ^~~~~~~~~

[sleeptightAnsiC]

After taking a look at the problem I see two solutions:

• Option 1 - remove guards from function definitions entirely, so we will get the behavior from before 455b404 - this is a very safe approach and it should work just fine everywhere but, if you bring your own sin/cos/memset... and so on, it will trigger a warning about unused function. Honestly, I think people who care about such warnings should be able to suppress them on their own, so it's not a big deal IMO, but we risk that someone will destroy this yet again after noticing those warnings.

• Option 2 - replace current guards with new ones like this: #if (NK_COS) == (nk_cos) - this will detect, if we are using user-defined macros and will prevent the warnings - however, this approach is fragile and I'm not sure, if C89 preprocess supports such constructs (maybe we could stringify the token and compare it to string literal instead?)

Anyway, here are patches for both options. I haven't done much testing as I'm not so familiar with Nuklear yet.

option1_safe.patch

diff --git a/src/nuklear_internal.h b/src/nuklear_internal.h
index a1523e8..ff02b58 100644
--- a/src/nuklear_internal.h
+++ b/src/nuklear_internal.h
@@ -96,18 +96,23 @@ NK_GLOBAL const struct nk_color nk_yellow = {255,255,0,255};
 /* math */
 #ifndef NK_INV_SQRT
 NK_LIB float nk_inv_sqrt(float n);
+#define NK_INV_SQRT nk_inv_sqrt
 #endif
 #ifndef NK_SIN
 NK_LIB float nk_sin(float x);
+#define NK_SIN nk_sin
 #endif
 #ifndef NK_COS
 NK_LIB float nk_cos(float x);
+#define NK_COS nk_cos
 #endif
 #ifndef NK_ATAN
 NK_LIB float nk_atan(float x);
+#define NK_ATAN nk_atan
 #endif
 #ifndef NK_ATAN2
 NK_LIB float nk_atan2(float y, float x);
+#define NK_ATAN2 nk_atan2
 #endif
 NK_LIB nk_uint nk_round_up_pow2(nk_uint v);
 NK_LIB struct nk_rect nk_shrink_rect(struct nk_rect r, float amount);
@@ -129,15 +134,18 @@ NK_LIB int nk_to_lower(int c);
 
 #ifndef NK_MEMCPY
 NK_LIB void* nk_memcopy(void *dst, const void *src, nk_size n);
+#define NK_MEMCPY nk_memcopy
 #endif
 #ifndef NK_MEMSET
 NK_LIB void nk_memset(void *ptr, int c0, nk_size size);
+#define NK_MEMSET nk_memset
 #endif
 NK_LIB void nk_zero(void *ptr, nk_size size);
 NK_LIB char *nk_itoa(char *s, long n);
 NK_LIB int nk_string_float_limit(char *string, int prec);
 #ifndef NK_DTOA
 NK_LIB char *nk_dtoa(char *s, double n);
+#define NK_DTOA nk_dtoa
 #endif
 NK_LIB int nk_text_clamp(const struct nk_user_font *font, const char *text, int text_len, float space, int *glyphs, float *text_width, nk_rune *sep_list, int sep_count);
 NK_LIB struct nk_vec2 nk_text_calculate_text_bounds(const struct nk_user_font *font, const char *begin, int byte_len, float row_height, const char **remaining, struct nk_vec2 *out_offset, int *glyphs, int op);
diff --git a/src/nuklear_math.c b/src/nuklear_math.c
index c24512c..a44b330 100644
--- a/src/nuklear_math.c
+++ b/src/nuklear_math.c
@@ -34,8 +34,6 @@
 ///  (it can actually approximate a lot more functions) can be
 ///  found here: www.lolengine.net/wiki/oss/lolremez
 */
-#ifndef NK_INV_SQRT
-#define NK_INV_SQRT nk_inv_sqrt
 NK_LIB float
 nk_inv_sqrt(float n)
 {
@@ -48,9 +46,6 @@ nk_inv_sqrt(float n)
     conv.f = conv.f * (threehalfs - (x2 * conv.f * conv.f));
     return conv.f;
 }
-#endif
-#ifndef NK_SIN
-#define NK_SIN nk_sin
 NK_LIB float
 nk_sin(float x)
 {
@@ -64,9 +59,6 @@ nk_sin(float x)
     NK_STORAGE const float a7 = +1.38235642404333740e-4f;
     return a0 + x*(a1 + x*(a2 + x*(a3 + x*(a4 + x*(a5 + x*(a6 + x*a7))))));
 }
-#endif
-#ifndef NK_COS
-#define NK_COS nk_cos
 NK_LIB float
 nk_cos(float x)
 {
@@ -83,9 +75,6 @@ nk_cos(float x)
     NK_STORAGE const float a8 = -1.8776444013090451e-5f;
     return a0 + x*(a1 + x*(a2 + x*(a3 + x*(a4 + x*(a5 + x*(a6 + x*(a7 + x*a8)))))));
 }
-#endif
-#ifndef NK_ATAN
-#define NK_ATAN nk_atan
 NK_LIB float
 nk_atan(float x)
 {
@@ -103,9 +92,6 @@ nk_atan(float x)
     u = u * x + -0.0004765437f;
     return u;
 }
-#endif
-#ifndef NK_ATAN2
-#define NK_ATAN2 nk_atan2
 NK_LIB float
 nk_atan2(float y, float x)
 {
@@ -129,7 +115,6 @@ nk_atan2(float y, float x)
     }
     return 0.0f; /* prevents warning */
 }
-#endif
 NK_LIB nk_uint
 nk_round_up_pow2(nk_uint v)
 {
diff --git a/src/nuklear_util.c b/src/nuklear_util.c
index b55602b..6d5c359 100644
--- a/src/nuklear_util.c
+++ b/src/nuklear_util.c
@@ -13,8 +13,6 @@ NK_LIB nk_bool nk_is_upper(int c){return (c >= 'A' && c <= 'Z') || (c >= 0xC0 &&
 NK_LIB int nk_to_upper(int c) {return (c >= 'a' && c <= 'z') ? (c - ('a' - 'A')) : c;}
 NK_LIB int nk_to_lower(int c) {return (c >= 'A' && c <= 'Z') ? (c - ('a' + 'A')) : c;}
 
-#ifndef NK_MEMCPY
-#define NK_MEMCPY nk_memcopy
 NK_LIB void*
 nk_memcopy(void *dst0, const void *src0, nk_size length)
 {
@@ -71,9 +69,6 @@ nk_memcopy(void *dst0, const void *src0, nk_size length)
 done:
     return (dst0);
 }
-#endif
-#ifndef NK_MEMSET
-#define NK_MEMSET nk_memset
 NK_LIB void
 nk_memset(void *ptr, int c0, nk_size size)
 {
@@ -125,7 +120,6 @@ nk_memset(void *ptr, int c0, nk_size size)
     #undef nk_wsize
     #undef nk_wmask
 }
-#endif
 NK_LIB void
 nk_zero(void *ptr, nk_size size)
 {
@@ -499,8 +493,6 @@ nk_itoa(char *s, long n)
     nk_strrev_ascii(s);
     return s;
 }
-#ifndef NK_DTOA
-#define NK_DTOA nk_dtoa
 NK_LIB char*
 nk_dtoa(char *s, double n)
 {
@@ -579,7 +571,6 @@ nk_dtoa(char *s, double n)
     *(c) = '\0';
     return s;
 }
-#endif
 #ifdef NK_INCLUDE_STANDARD_VARARGS
 #ifndef NK_INCLUDE_STANDARD_IO
 NK_INTERN int

option2_hacky.patch

diff --git a/src/nuklear_internal.h b/src/nuklear_internal.h
index a1523e8..ff02b58 100644
--- a/src/nuklear_internal.h
+++ b/src/nuklear_internal.h
@@ -96,18 +96,23 @@ NK_GLOBAL const struct nk_color nk_yellow = {255,255,0,255};
 /* math */
 #ifndef NK_INV_SQRT
 NK_LIB float nk_inv_sqrt(float n);
+#define NK_INV_SQRT nk_inv_sqrt
 #endif
 #ifndef NK_SIN
 NK_LIB float nk_sin(float x);
+#define NK_SIN nk_sin
 #endif
 #ifndef NK_COS
 NK_LIB float nk_cos(float x);
+#define NK_COS nk_cos
 #endif
 #ifndef NK_ATAN
 NK_LIB float nk_atan(float x);
+#define NK_ATAN nk_atan
 #endif
 #ifndef NK_ATAN2
 NK_LIB float nk_atan2(float y, float x);
+#define NK_ATAN2 nk_atan2
 #endif
 NK_LIB nk_uint nk_round_up_pow2(nk_uint v);
 NK_LIB struct nk_rect nk_shrink_rect(struct nk_rect r, float amount);
@@ -129,15 +134,18 @@ NK_LIB int nk_to_lower(int c);
 
 #ifndef NK_MEMCPY
 NK_LIB void* nk_memcopy(void *dst, const void *src, nk_size n);
+#define NK_MEMCPY nk_memcopy
 #endif
 #ifndef NK_MEMSET
 NK_LIB void nk_memset(void *ptr, int c0, nk_size size);
+#define NK_MEMSET nk_memset
 #endif
 NK_LIB void nk_zero(void *ptr, nk_size size);
 NK_LIB char *nk_itoa(char *s, long n);
 NK_LIB int nk_string_float_limit(char *string, int prec);
 #ifndef NK_DTOA
 NK_LIB char *nk_dtoa(char *s, double n);
+#define NK_DTOA nk_dtoa
 #endif
 NK_LIB int nk_text_clamp(const struct nk_user_font *font, const char *text, int text_len, float space, int *glyphs, float *text_width, nk_rune *sep_list, int sep_count);
 NK_LIB struct nk_vec2 nk_text_calculate_text_bounds(const struct nk_user_font *font, const char *begin, int byte_len, float row_height, const char **remaining, struct nk_vec2 *out_offset, int *glyphs, int op);
diff --git a/src/nuklear_math.c b/src/nuklear_math.c
index c24512c..74e09a3 100644
--- a/src/nuklear_math.c
+++ b/src/nuklear_math.c
@@ -34,8 +34,7 @@
 ///  (it can actually approximate a lot more functions) can be
 ///  found here: www.lolengine.net/wiki/oss/lolremez
 */
-#ifndef NK_INV_SQRT
-#define NK_INV_SQRT nk_inv_sqrt
+#if (NK_INV_SQRT) == (nk_inv_sqrt)
 NK_LIB float
 nk_inv_sqrt(float n)
 {
@@ -49,8 +48,7 @@ nk_inv_sqrt(float n)
     return conv.f;
 }
 #endif
-#ifndef NK_SIN
-#define NK_SIN nk_sin
+#if (NK_SIN) == (nk_sin)
 NK_LIB float
 nk_sin(float x)
 {
@@ -65,8 +63,7 @@ nk_sin(float x)
     return a0 + x*(a1 + x*(a2 + x*(a3 + x*(a4 + x*(a5 + x*(a6 + x*a7))))));
 }
 #endif
-#ifndef NK_COS
-#define NK_COS nk_cos
+#if (NK_COS) == (nk_cos)
 NK_LIB float
 nk_cos(float x)
 {
@@ -84,8 +81,7 @@ nk_cos(float x)
     return a0 + x*(a1 + x*(a2 + x*(a3 + x*(a4 + x*(a5 + x*(a6 + x*(a7 + x*a8)))))));
 }
 #endif
-#ifndef NK_ATAN
-#define NK_ATAN nk_atan
+#if (NK_ATAN) == (nk_atan)
 NK_LIB float
 nk_atan(float x)
 {
@@ -104,8 +100,7 @@ nk_atan(float x)
     return u;
 }
 #endif
-#ifndef NK_ATAN2
-#define NK_ATAN2 nk_atan2
+#if (NK_ATAN2) == (nk_atan2)
 NK_LIB float
 nk_atan2(float y, float x)
 {
diff --git a/src/nuklear_util.c b/src/nuklear_util.c
index b55602b..e6d731d 100644
--- a/src/nuklear_util.c
+++ b/src/nuklear_util.c
@@ -13,8 +13,7 @@ NK_LIB nk_bool nk_is_upper(int c){return (c >= 'A' && c <= 'Z') || (c >= 0xC0 &&
 NK_LIB int nk_to_upper(int c) {return (c >= 'a' && c <= 'z') ? (c - ('a' - 'A')) : c;}
 NK_LIB int nk_to_lower(int c) {return (c >= 'A' && c <= 'Z') ? (c - ('a' + 'A')) : c;}
 
-#ifndef NK_MEMCPY
-#define NK_MEMCPY nk_memcopy
+#if (NK_MEMCPY) == (nk_memcpy)
 NK_LIB void*
 nk_memcopy(void *dst0, const void *src0, nk_size length)
 {
@@ -72,8 +71,7 @@ done:
     return (dst0);
 }
 #endif
-#ifndef NK_MEMSET
-#define NK_MEMSET nk_memset
+#if (NK_MEMSET) == (nk_memset)
 NK_LIB void
 nk_memset(void *ptr, int c0, nk_size size)
 {
@@ -499,8 +497,7 @@ nk_itoa(char *s, long n)
     nk_strrev_ascii(s);
     return s;
 }
-#ifndef NK_DTOA
-#define NK_DTOA nk_dtoa
+#if (NK_DTOA) == (nk_dtoa)
 NK_LIB char*
 nk_dtoa(char *s, double n)
 {

Let me know what do ya think and if I should create a PR? If yes then which patch shall I choose?

EDIT: there is also Option 3: add additional internal macros that will be defined inside of src/nuklear_internal.h only when user does not define it's own sin/cos/memcpy/etc, and guard the functions with those macros. This will bring more code and might be quite confusing but should work just fine.