Fix occasionally failing errors test #365
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of exact messages. The errors test asserted exact error messages and count, but concurrent processing causes the error detection to fire in different orders depending on thread scheduling. Changed the test to verify error detection works by checking for expected error patterns: - Skipped frame index detection - Duplicate frame index detection - Non-monotonic pts detection This maintains test coverage while being resilient to thread scheduling variations. Signed-off-by: Peter A. <ink.splatters@pm.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix occasionally failing errors test by checking error patterns instead of
exact messages.
The errors test asserted exact error messages and count, but concurrent
processing causes the error detection to fire in different orders depending on
thread scheduling.
Resolves #364