Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google ADs in documentation #342

Open
Lastique opened this issue Oct 12, 2024 · 0 comments · May be fixed by #343
Open

Google ADs in documentation #342

Lastique opened this issue Oct 12, 2024 · 0 comments · May be fixed by #343

Comments

@Lastique
Copy link
Contributor

ImageMagick version

6.9.13-17

Operating system

Linux

Operating system, version and so on

N/A

Description

Local HTML documentation contains references to Google ADs and counters. For example:

ImageMagick6/www/search.html

Lines 36 to 37 in a61d721

<script async src="https://localhost/pagead/js/adsbygoogle.js?client=ca-pub-3129977114552745" crossorigin="anonymous"></script>
<script async src="https://cse.google.com/cse.js?cx=006134137889097767902:turn9fku95u"> </script>

References like these are present in all html files.

Please remove these references as these can pose a privacy breach. Local documentation should not use references to external resources to be viewable on the local machine.

Steps to Reproduce

  1. Download ImageMagick 6.9.13-17.
  2. Look into html files.

Images

N/A.
Lastique added a commit to Lastique/ImageMagick6 that referenced this issue Oct 12, 2024
@Lastique
Remove Google ADs from HTML documentation.
992ca09 
This removes the potential privacy breach due to referencing Google
resources while viewing local documentation.

Closes ImageMagick#342.
@Lastique Lastique linked a pull request Oct 12, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Google ADs from HTML documentation Lastique/ImageMagick6
1 participant
@Lastique