-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sample to be able use NativeAOT #379
base: master
Are you sure you want to change the base?
Conversation
Hey @kant2002, thanks for the submission here. In newer versions of Veldrid (of which there are only beta releases...), SharpDX has actually been replaced by Vortice. I think a better approach here would be to update the sample projects to reference Veldrid 4.9.0-beta2 and see if NativeAOT works out of the box. If it doesn't, we will probably need a slightly different rd.xml file, but chances are much higher that it will work. |
I did update to beta, and problem just move to Vortice. Actual root cause is missing trimming annotations for |
edc962a
to
a5a89c3
Compare
sigh, https://github.com/SharpGenTools/SharpGenTools/blob/7917a51b8203bcdd3e3fc0750b7f93f1888838ea/SharpGen.Runtime/MarshallingHelpers.cs#L18-L20 we already have annotations, but they are not part of latest release and Jeremy is overworked. Probably have to live with this for now. |
Let's see how it goes with SharpGenTools/SharpGenTools#229 |
good news: amerkoleci/Vortice.Windows#379 (comment) |
I think Veldrid should be recompiled, since If I manually bump version by adding
|
I would suggest to update vortice to latest 2.3.0 in veldrid and then use that veldrid build for imgui. I'll try to keep method names backward compatible in future. |
that's what I plan to do. Thankfully in my case Veldrid and ImGui.Net have same maintainer, so things would be easiers to handle. I just let you know that renamig in minor version cause problems. I understand that if you are alone, it's hard to keep track of everything. |
PR ready: veldrid/veldrid#478 |
rd.xml file is workaround to SharpDx limitations.
a5a89c3
to
1b797d4
Compare
After updating to latest Veldrid ImgUI.Net works with NativeAOT out of the box! Thank you guys! |
rd.xml file is workaround to SharpDx limitations.