Skip to content

Conversation

@IlinJoy
Copy link
Owner

@IlinJoy IlinJoy commented Aug 3, 2025

  1. Task: link
  2. Screenshot:
image image
  1. Deploy: link
  2. Done 04.08.2025 / deadline 04.08.2025
  3. Score: 100 / 100
  • State management is properly implemented with either Redux Toolkit or Zustand - 35
  • Selected items are managed through the state store, selected items are persistent across pages - 25
  • Flyout component is showed/hidden based on the presence of selected items, displays the number of selected items - 15
  • "Unselect all" button and "Download" button work according to the requirements - 10
  • User can switch the theme of the application using Context API - 15

Penalties

TypeScript & Code Quality

  • TypeScript isn't used: -95 points
  • Usage of any: -20 points per each
  • Usage of ts-ignore: -20 points per each
  • Presence of code-smells (God-object, chunks of duplicate code), commented code sections: -10 points per each

Test Coverage

  • Statement coverage below 80% (≥70%): -10 points
  • Statement coverage below 70% (≥50%): -30 points
  • All coverage metrics below 50%: -50 points

React Best Practices

  • Direct DOM manipulations inside the React components (except toggling theme-related classes/attributes on document.documentElement within useEffect/useLayoutEffect/useInsertionEffect hooks): -50 points per each

External Dependencies

  • Usage of component libraries, e.g. Material UI, Ant Design: -100 points

Project Management

  • Commits after the deadline: -40 points
  • Pull Request doesn't follow guideline (including checkboxes in Score) PR example: -10 points

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants