-
Notifications
You must be signed in to change notification settings - Fork 2
fix: restrict DotPaths inference recursion and ignore built-in types #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes type inference issues by adding recursion depth limits and excluding built-in types from DotPaths traversal. The changes prevent excessive type recursion and avoid attempting to traverse JavaScript built-in objects that shouldn't be decomposed into dot-notation paths.
Changes:
- Added
NonTraversableunion type to exclude built-in types (functions, arrays, dates, etc.) - Implemented depth-limiting mechanism using
Prevtuple type to cap recursion at 5 levels - Updated
DotPathstype to check depth and non-traversable types before recursing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pull Request Test Coverage Report for Build 21473213785Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.