Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize _calcMaxChunkSize performance - 7.1.x #3721

Merged
merged 11 commits into from
Jan 28, 2019
Merged

Optimize _calcMaxChunkSize performance - 7.1.x #3721

merged 11 commits into from
Jan 28, 2019

Conversation

DiyanDimitrov
Copy link
Contributor

@DiyanDimitrov DiyanDimitrov commented Jan 24, 2019 •
edited
Loading

Closes #3409

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@DiyanDimitrov DiyanDimitrov changed the base branch from master to 7.1.x January 24, 2019 16:07
@DiyanDimitrov DiyanDimitrov added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jan 25, 2019
ViktorSlavov
ViktorSlavov previously approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@ViktorSlavov ViktorSlavov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the combo.spec look okay.
The change broke the functionality navigateDown (which was expecting 1 item to be out of view, currently are 2), I've pushed a fixed in the branch

rkaraivanov
rkaraivanov previously approved these changes Jan 25, 2019
View reviewed changes
@DiyanDimitrov DiyanDimitrov added 🛠️ status: in-development Issues and PRs with active development on them and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jan 25, 2019
@DiyanDimitrov DiyanDimitrov added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jan 28, 2019
@gedinakova gedinakova added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jan 28, 2019
@rkaraivanov rkaraivanov merged commit c6a30ee into 7.1.x Jan 28, 2019
@rkaraivanov rkaraivanov deleted the ddimitrov/fix-3409-7.1.x branch January 28, 2019 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorSlavov ViktorSlavov ViktorSlavov approved these changes

@rkaraivanov rkaraivanov rkaraivanov approved these changes

@MayaKirova MayaKirova Awaiting requested review from MayaKirova

Assignees

@gedinakova gedinakova

Labels
grid: general version: 7.1.x virtualization ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DiyanDimitrov @rkaraivanov @ViktorSlavov @gedinakova