Skip to content

fix(avatar): allow for more robust styling of the avatar to fix border issues #3445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 3, 2019
Merged

fix(avatar): allow for more robust styling of the avatar to fix border issues #3445

merged 10 commits into from
Jan 3, 2019

Conversation

simeonoff
Copy link
Collaborator

Closes #3444

Additional information (check all that apply):

  • Bug Fix

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code

@simeonoff simeonoff added avatar Avatar component ❌ status: awaiting-test PRs awaiting manual verification refactoring labels Dec 13, 2018
@simeonoff simeonoff changed the title refactor(avatar): allow for more robust styling of the avatar fix(avatar): allow for more robust styling of the avatar to fix border issues Dec 13, 2018
bkulov
bkulov previously approved these changes Dec 17, 2018
View reviewed changes
@npaunov npaunov added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Dec 17, 2018
bkulov
bkulov previously approved these changes Dec 17, 2018
View reviewed changes
@zdrawku zdrawku changed the base branch from master to 7.1.x December 18, 2018 14:40
@zdrawku zdrawku merged commit c84e02e into 7.1.x Jan 3, 2019
@zdrawku zdrawku deleted the avatar-box-sizing branch January 3, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdrawku zdrawku zdrawku approved these changes

@kdinev kdinev Awaiting requested review from kdinev

@rkaraivanov rkaraivanov Awaiting requested review from rkaraivanov

+1 more reviewer

@bkulov bkulov bkulov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@npaunov npaunov

Labels
avatar Avatar component refactoring version: 7.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@simeonoff @bkulov @zdrawku @npaunov @SAndreeva