Fix blank space when navigating to next page #2984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrobakova
added
❌ status: awaiting-test
MayaKirova
requested changes
Nov 12, 2018
projects/igniteui-angular/src/lib/directives/for-of/for_of.directive.ts
Outdated
Show resolved
Hide resolved
MayaKirova
previously approved these changes
Nov 12, 2018
MayaKirova
approved these changes
Nov 13, 2018
|
NB: Please also verify 2987. |
hanastasov
added
💥 status: in-test
hanastasov
approved these changes
Nov 19, 2018
hanastasov
added
✅ status: verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2957
Closes #2987
Additional information related to this pull request:
Update method _updateVScrollOffset to get correct scrollOffset