Repository navigation
fix(tabs): call markForCheck when updating selected tab - 22.2.x - #17736
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The fix covers every affected deferred selection branch with focused zoneless regression tests.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes zoneless tab selection rendering by explicitly scheduling change detection after deferred selection updates.
Changes:
- Calls
markForCheck()after all deferred tab-selection mutations. - Adds zoneless tests for initialization and dynamic tab collections.
| File | Description |
|---|---|
tabs.directive.ts |
Schedules checks after asynchronous selection updates. |
tabs.component.spec.ts |
Tests zoneless selection rendering paths. |
tabs-components.spec.ts |
Adds signal-backed test hosts for dynamic tabs. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
|
@copilot , update the changelog.md with information about this bug fix. This should be added in the latest 22.2.x version. |
Co-authored-by: igdmdimitrov <49060557+igdmdimitrov@users.noreply.github.com>
Added the |
I reviewed the findings. PR #17746 is the separate 21.2.x backport; its path and CSS-class comments are specific to that version’s layout. In this 22.2.x branch, the import path and |
Closes #17676
Type of Change (check all that apply):
How Has This Been Tested?
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)