Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted style fix is consistent with the component structure and has comprehensive regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes Excel-style filter density when custom height constraints are used.
Changes:
- Moves sizing flags to the filter host.
- Adds density and height regression coverage.
- Documents sizing behavior.
| File | Description |
|---|---|
grid-samples.spec.ts |
Adds the external-outlet test fixture. |
grid-filtering-ui.spec.ts |
Tests densities, bounds, and runtime updates. |
README.md |
Documents filter sizing behavior. |
_base.scss |
Preserves sizing variables independently of height constraints. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17589
Description
Fix Excel-style filter menu density when
minHeightormaxHeightis set.sizable()to the.igx-excel-filterbase class so sizing flags remain available regardless of custom height constraints.--component-sizefrom the host instead of redeclaring it.__sizing.Motivation / Context
Setting either height input removes the
__sizingclass, which previously also removed the sizing flags. Without a sizing ancestor—for example, in an external outlet—the menu fell back to large padding and gaps even when--ig-sizeselected small or medium density.Initializing sizing on the host separates density from height constraints and preserves the existing custom-height behavior.
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
IgxGridExcelStyleFilteringComponent)How Has This Been Tested?
Added regression coverage for:
minHeightonly,maxHeightonly, and both bounds.Test Configuration:
Checklist:
feature/README.MDupdates for the feature docsREADME.MD— N/A: no new feature.CHANGELOG.MDupdates for newly added functionality — N/A: bug fix; released-version entries are unchanged.ng updatemigrations for the breaking changes (migrations guidelines) — N/A: no breaking changes.