-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(grid): add FormattedValuesSortingStrategy for sorting by formatted values - master #14538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Use the tree-grid groupby sample
-
Add the strategy in the class:
public formattedValuesSortingStrategy = new FormattedValuesSortingStrategy();Run the sample, error is thrown in console:
This is a good ocasion to apply TDD approach :) First add a unit test for this scenario that will be failing with this error, and then add the fix.
@hanastasov It appears that the error you're encountering is due to the fact that The scenario you described might differ and could be indicative of another underlying issue and further investigation into the specific implementation details might be required. |
Adding a "do-not-merge" tag to this pull request so we can accommodate the upcoming mass merges more effectively. |
…into ganastasov/feat-14442-master
…into ganastasov/feat-14442-master
…into ganastasov/feat-14442-master
Closes #14442
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)