Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IgxGridHeaderGroupComponent should have preset min width #3071

Closed
SAndreeva opened this issue Nov 21, 2018 · 1 comment · Fixed by #3309
Closed

IgxGridHeaderGroupComponent should have preset min width #3071

SAndreeva opened this issue Nov 21, 2018 · 1 comment · Fixed by #3309
Assignees
@bkulov @SAndreeva
Labels
🐛 bug Any issue that describes a bug grid: general version: 7.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@SAndreeva
Copy link
Contributor

Description

IgxGridHeaderGroupComponent should have preset min width

  • igniteui-angular version: 6.2.x
  • browser: N/A

Steps to reproduce

  1. Switch to SAndreeva/header-group-component-6.2.x
  2. Run Grid Column Moving demo
  3. Inspect the the 'ID' column header group

Result

IgxGridHeaderGroupComponent is sized to 40px as this is the width set on the column. IgxGridHeaderComponent and IgxGridFilteringCellComponent are 48px as they have paddings.
Therefore cells and headers looked misaligned, the resize handler on the header is not shown at the expected place.

Expected result

The IgxGridHeaderGroupComponent should not be able to go below a certain min width.
@SAndreeva SAndreeva mentioned this issue Nov 21, 2018
Merged
@simeonoff
Copy link
Collaborator

@SAndreeva This is not something that can be fixed by setting css properties on the item class as the min-width value is set via HostBinding.

@simeonoff simeonoff assigned SAndreeva and unassigned simeonoff and desig9stein Nov 22, 2018
SAndreeva added a commit that referenced this issue Dec 4, 2018
@SAndreeva
fix(grid): set min width to header groups #3071
2ae31f5
@SAndreeva SAndreeva added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Dec 4, 2018
@SAndreeva SAndreeva mentioned this issue Dec 4, 2018
Merged
14 tasks
SAndreeva added a commit that referenced this issue Dec 4, 2018
@SAndreeva
chore(*): remove forgotten f from spec file #3071
4c1710b
SAndreeva added a commit that referenced this issue Dec 4, 2018
@SAndreeva
fix(grid): set min width to header groups #3071
699c8ae
@SAndreeva SAndreeva mentioned this issue Dec 4, 2018
Merged
14 tasks
@SAndreeva SAndreeva added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Dec 4, 2018
SAndreeva added a commit that referenced this issue Dec 5, 2018
@SAndreeva
chore(*): fix lint errors #3071
549d08a
SAndreeva added a commit that referenced this issue Dec 5, 2018
@SAndreeva
chore(*): fix lint errors #3071
c6bbcd7
SAndreeva added a commit that referenced this issue Dec 7, 2018
@SAndreeva
fix(grid): address review comments #3071
881388e
SAndreeva added a commit that referenced this issue Dec 7, 2018
@SAndreeva
fix(grid): address review comments #3071
dec2603
SAndreeva added a commit that referenced this issue Dec 7, 2018
@SAndreeva
feat(grid): address review comments #3071
6d37088
SAndreeva added a commit that referenced this issue Dec 7, 2018
@SAndreeva
fix(grid): add additional check that column width is not % #3071
aaeec0d
SAndreeva added a commit that referenced this issue Dec 7, 2018
@SAndreeva
fix(grid): add additional check that column width is not % #3071
b51a4f6
SAndreeva added a commit that referenced this issue Dec 7, 2018
@SAndreeva
fix(grid): extend percentage check #3071
0941378
SAndreeva added a commit that referenced this issue Dec 7, 2018
@SAndreeva
fix(grid): extend percentage check #3071
9711f26
bkulov pushed a commit that referenced this issue Dec 7, 2018
chore(*): Remove bug fix from CHANGELOG.md (#3071)
ec77eb1
@bkulov bkulov mentioned this issue Dec 7, 2018
Merged
SAndreeva added a commit that referenced this issue Dec 10, 2018
@SAndreeva
fix(grid): add a test to cover % column widths #3071
647ddff
@SAndreeva SAndreeva mentioned this issue Dec 10, 2018
Merged
14 tasks
SAndreeva added a commit that referenced this issue Dec 11, 2018
@SAndreeva
fix(grid): set min width to header group in code #3071
52532fa
This was referenced Dec 11, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkulov bkulov

@SAndreeva SAndreeva

Labels
🐛 bug Any issue that describes a bug grid: general version: 7.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(grid): set min width to header groups programmatically IgniteUI/igniteui-angular
4 participants
@bkulov @simeonoff @SAndreeva @desig9stein