Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization (i18n) not available for inputs/buttons on the grid filtering dialog #2517

Closed
gdayori opened this issue Aug 29, 2018 · 7 comments
Assignees
Labels
grid: filter-ui grid: general 🔣 i18n version: 6.0.x version: 7.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@gdayori
Copy link

gdayori commented Aug 29, 2018

Description

Localization (i18n) not available for inputs/buttons on the grid filtering dialog, for example "value" (null text for inputs), "AND", "OR", "RESET" and "CLOSE".

  • igniteui-angular version: 6.1.4
  • browser: anything

Steps to reproduce

Please see the attached image.

Result

No way to localize some text on the filter dialog.

Expected result

Text on the filter dialog can be localized.

Attachments

igx-grid-filtering-dialog

@zdrawku
Copy link
Contributor

zdrawku commented Aug 29, 2018

@gdayori we are waiting for runtime localization feature of Angular to be implemented in order to use it.

This is the issue in the angular repository, and as I see they are currently working on it (5 day comment), the runtime part is done without the the compliler part yet.

@SlavUI
Copy link
Contributor

SlavUI commented Nov 9, 2018

@bkulov please start working on this Issue from Monday.

@juancarlosbaezpozos
Copy link

I know the pipe makes the translation but how can I change the locale from "en-US" to another. the locale must be declared in the HTML as attribute?. thank you in advance

@bkulov
Copy link
Contributor

bkulov commented Nov 13, 2018

@juancarlosbaezpozos Note that this feature is still in development. Angular have some tools to provide localization but only for client applications and not for components. So we are going to implement a temporary solution for the time being.
As for the LOCALE_ID - it's Angular DI token providing the current application locale. If you provide Angular CLI localizations to your application you could provide it in the command line ng serve --configuration=fr. Or you could provide it into the providers array of ngModule, Component, etc. like this providers: [ { provide: LOCALE_ID, useValue: 'fr' } ],.

For more info take a look at the following article. Note that we will be using only the DI token and not the whole Angular localization process. Once done we will provide an extensive documentation with samples how the localization could be done.
https://angular.io/guide/i18n

sstoyanovIG added a commit that referenced this issue Nov 29, 2018
sstoyanovIG added a commit that referenced this issue Nov 29, 2018
sstoyanovIG added a commit that referenced this issue Nov 29, 2018
sstoyanovIG added a commit that referenced this issue Nov 30, 2018
sstoyanovIG added a commit that referenced this issue Nov 30, 2018
@bkulov bkulov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. version: 6.0.x version: 7.0.x and removed 🛠️ status: in-development Issues and PRs with active development on them labels Dec 3, 2018
bkulov pushed a commit that referenced this issue Dec 4, 2018
bkulov pushed a commit that referenced this issue Dec 4, 2018
bkulov pushed a commit that referenced this issue Dec 4, 2018
@zdrawku
Copy link
Contributor

zdrawku commented Dec 5, 2018

@bkulov do we consider this issue as completed?

@bkulov
Copy link
Contributor

bkulov commented Dec 5, 2018

@zdrawku Not yet. We're working on a separate repo containing the localized string resources for JA and JP. When it's done I'll close this issue.

@bkulov
Copy link
Contributor

bkulov commented Dec 19, 2018

This is the documentation we have for the localization:
https://www.infragistics.com/products/ignite-ui-angular/angular/components/localization.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: filter-ui grid: general 🔣 i18n version: 6.0.x version: 7.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

No branches or pull requests

6 participants