Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drm-platform: support wl_resource exports, drmModeAddFB2 fallback #145

Merged
merged 3 commits into from
Sep 10, 2019

Conversation

zdobersek
Copy link
Contributor

Add support for displaying wl_resource exports, first importing those objects
into gbm via GBM_BO_IMPORT_WL_BUFFER functionality and continuing with gbm_bo.

The DRM update is now moved into a standalone helper function and extended to
allow falling back to using drmModeAddFB2 if the with-modifiers import failed.

Add support for displaying wl_resource exports, first importing those objects
into gbm via GBM_BO_IMPORT_WL_BUFFER functionality and continuing with gbm_bo.

The DRM update is now moved into a standalone helper function and extended to
allow falling back to using drmModeAddFB2 if the with-modifiers import failed.
Copy link
Member

@aperezdc aperezdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a few comments, please take a look at them before merging the patch.

Thanks! 👍

platform/cog-platform-drm.c Outdated Show resolved Hide resolved
platform/cog-platform-drm.c Outdated Show resolved Hide resolved
platform/cog-platform-drm.c Show resolved Hide resolved
platform/cog-platform-drm.c Outdated Show resolved Hide resolved
@zdobersek zdobersek merged commit 6355dd5 into master Sep 10, 2019
@aperezdc
Copy link
Member

Thanks again, @zdobersek!

@zdobersek zdobersek deleted the zdobersek/drm-platform branch October 26, 2020 15:51
EinarArnason pushed a commit to EinarArnason/cog that referenced this pull request May 16, 2022
…alia#145)

* drm-platform: support wl_resource exports, drmModeAddFB2 fallback

Add support for displaying wl_resource exports, first importing those objects
into gbm via GBM_BO_IMPORT_WL_BUFFER functionality and continuing with gbm_bo.

The DRM update is now moved into a standalone helper function and extended to
allow falling back to using drmModeAddFB2 if the with-modifiers import failed.

* platform-drm: harden plane cout logic.

* platform-drm: add meaningful warning logging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants